Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github action to test the setup and frameworks #16

Merged
merged 24 commits into from
Jul 23, 2023

Conversation

joanhey
Copy link
Contributor

@joanhey joanhey commented Jul 22, 2023

Still work in progress. Ready to be merged.

We need a better error handling in the check.sh.
Now it's failing, but don't return any error to mark the job as fail.
Some frameworks fail, with the initial setup. Perhaps we need to add more extensions.

Later we can add a bench of ~10s, but first we need to create a config for the runner (only 2 cpu) and 50 treads and 500 connections is too many.

PD: to view in my repo
https://github.com/joanhey/PHP-Frameworks-Bench/actions/runs/5633201294/job/15261843959

Update: seems that only fail the permissions now
Update: only fail Laravel now, and seems to permissions too
https://github.com/joanhey/PHP-Frameworks-Bench/actions/runs/5633660738/job/15262807159

All the checks pass now:
https://github.com/joanhey/PHP-Frameworks-Bench/actions/runs/5636218622/job/15268055873

@joanhey
Copy link
Contributor Author

joanhey commented Jul 23, 2023

The problem with Laravel is the artisan optimize than it's also deprecated.

image
https://blog.runcloud.io/how-to-optimize-laravel/

image
https://stackoverflow.com/questions/31895854/laravel-artisan-optimize-best-practices
....

@joanhey
Copy link
Contributor Author

joanhey commented Jul 23, 2023

Ready to be merged !!!

@myaaghubi
Copy link
Owner

I checked it saw no problems
so nice job 👍

@myaaghubi myaaghubi changed the base branch from main to dev July 23, 2023 12:30
@myaaghubi myaaghubi merged commit 05ff7de into myaaghubi:dev Jul 23, 2023
@joanhey joanhey deleted the gh-action branch July 23, 2023 14:21
myaaghubi added a commit that referenced this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants