Undo invalid optimization with stronger comment

mybatis · May 7, 2023 · c596ae7 · c596ae7
1 parent 28abe61
commit c596ae7
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/main/java/org/apache/ibatis/migration/operations/ScriptRunner.java b/src/main/java/org/apache/ibatis/migration/operations/ScriptRunner.java
@@ -243,7 +243,9 @@ private void executeStatement(String command) throws SQLException {
       }
       try {
         boolean hasResults = statement.execute(sql);
-        while (hasResults || statement.getUpdateCount() != -1) {
+        // DO NOT try to 'imporove' the condition even if IDE tells you to!
+        // It's important that getUpdateCount() is called here.
+        while (!(!hasResults && statement.getUpdateCount() == -1)) {
           checkWarnings(statement);
           printResults(statement, hasResults);
           hasResults = statement.getMoreResults();