Merge pull request #1430 from dawwin/feature/cursor_test_docs_update

Removed unnecessary ordering from cursor tests and updated comments
mybatis · Jan 7, 2019 · 3668bfa · 3668bfa
2 parents 8894484 + d547ab7
commit 3668bfa
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/main/java/org/apache/ibatis/cursor/Cursor.java b/src/main/java/org/apache/ibatis/cursor/Cursor.java
@@ -20,7 +20,8 @@
 /**
  * Cursor contract to handle fetching items lazily using an Iterator.
  * Cursors are a perfect fit to handle millions of items queries that would not normally fits in memory.
- * Cursor SQL queries must be ordered (resultOrdered="true") using the id columns of the resultMap.
+ * If you use collections in resultMaps then cursor SQL queries must be ordered (resultOrdered="true")
+ * using the id columns of the resultMap.
  *
  * @author Guillaume Darmont / guillaume@dropinocean.com
  */

diff --git a/src/test/java/org/apache/ibatis/submitted/cursor_simple/Mapper.xml b/src/test/java/org/apache/ibatis/submitted/cursor_simple/Mapper.xml
@@ -22,8 +22,8 @@
 
 <mapper namespace="org.apache.ibatis.submitted.cursor_simple.Mapper">
 
-	<select id="getAllUsers" resultMap="results" resultOrdered="true">
-		select * from users order by id
+	<select id="getAllUsers" resultMap="results">
+		select * from users
 	</select>
 
 	<resultMap type="org.apache.ibatis.submitted.cursor_simple.User" id="results">