Skip to content

Commit

Permalink
[maven-release-plugin] prepare release mybatis-3.4.2
Browse files Browse the repository at this point in the history
  • Loading branch information
harawata committed Jan 2, 2017
1 parent 3c9f435 commit 44c0962
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions pom.xml
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
Copyright 2009-2016 the original author or authors.
Copyright 2009-2017 the original author or authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand All @@ -27,7 +27,7 @@
</parent>

<artifactId>mybatis</artifactId>
<version>3.4.2-SNAPSHOT</version>
<version>3.4.2</version>
<packaging>jar</packaging>

<name>mybatis</name>
Expand All @@ -51,7 +51,7 @@
<email>selva.andre@gmail.com</email>
</contributor>
<contributor>
<name>Antonio S&#225;nchez</name>
<name>Antonio Sánchez</name>

This comment has been minimized.

Copy link
@hazendaz

hazendaz Feb 21, 2017

Member

@harawata This is likely to cause the famous UTF-8 BOM which causes us problems. That is why those were translated previously. Maybe something along the way handles this better now but wanted mention it in case it comes around again.

This comment has been minimized.

Copy link
@harawata

harawata Feb 21, 2017

Author Member

@hazendaz ,
I didn't realize it, sorry. I am pretty sure I did not edit it manually. Could it be some plugin?
It didn't happen when I released 3.4.1, though.

This comment has been minimized.

Copy link
@hazendaz

hazendaz Feb 21, 2017

Member

Interesting that it happened automatically. Quite possibly a plugin did do it. Well, something to at least keep an eye on.

This comment has been minimized.

Copy link
@hazendaz

hazendaz Feb 21, 2017

Member

Anyway, if it pops up again, it is an obvious thing. The POM will change and using something like notepad++ will show that its type changed with a bom marker in the first position. It's easy to switch back but becomes a pain. It didn't do it to me when I rebased so maybe all is well now.

This comment has been minimized.

Copy link
@harawata

harawata Feb 21, 2017

Author Member

I hope so. I knew some editors trying to add BOM when saving UTF-8 files, but recent editors should be fine (or configurable at least). Let's see how it goes :)

<email>juntandolineas@gmail.com</email>
</contributor>
<contributor>
Expand Down Expand Up @@ -103,7 +103,7 @@
<email>riccardo.cossu@gmail.com</email>
</contributor>
<contributor>
<name>Tom&#225;&#353; Neuberg</name>
<name>Tomáš Neuberg</name>
<email>neuberg@m-atelier.cz</email>
</contributor>
</contributors>
Expand All @@ -112,7 +112,7 @@
<url>http://github.com/mybatis/mybatis-3</url>
<connection>scm:git:ssh://github.com/mybatis/mybatis-3.git</connection>
<developerConnection>scm:git:ssh://git@github.com/mybatis/mybatis-3.git</developerConnection>
<tag>HEAD</tag>
<tag>mybatis-3.4.2</tag>
</scm>
<issueManagement>
<system>GitHub Issue Management</system>
Expand Down Expand Up @@ -364,7 +364,7 @@
<properties>
<maven.compiler.testTarget>1.6</maven.compiler.testTarget>
<maven.compiler.testSource>1.6</maven.compiler.testSource>
<maven.compiler.testCompilerArgument></maven.compiler.testCompilerArgument>
<maven.compiler.testCompilerArgument />
</properties>
<build>
<pluginManagement>
Expand All @@ -391,7 +391,7 @@
<properties>
<maven.compiler.testTarget>1.7</maven.compiler.testTarget>
<maven.compiler.testSource>1.7</maven.compiler.testSource>
<maven.compiler.testCompilerArgument></maven.compiler.testCompilerArgument>
<maven.compiler.testCompilerArgument />
</properties>
<build>
<pluginManagement>
Expand Down

0 comments on commit 44c0962

Please sign in to comment.