fix: Double-checked locking for logConstructor

mybatis · May 2, 2024 · 55ce51c · 55ce51c
1 parent cddff0d
commit 55ce51c
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/src/main/java/org/apache/ibatis/logging/LogFactory.java b/src/main/java/org/apache/ibatis/logging/LogFactory.java
@@ -30,7 +30,7 @@ public final class LogFactory {
   public static final String MARKER = "MYBATIS";
 
   private static final ReentrantLock lock = new ReentrantLock();
-  private static Constructor<? extends Log> logConstructor;
+  private static volatile Constructor<? extends Log> logConstructor;
 
   static {
     tryImplementation(LogFactory::useSlf4jLogging);
@@ -95,10 +95,14 @@ public static void useNoLogging() {
 
   private static void tryImplementation(Runnable runnable) {
     if (logConstructor == null) {
-      try {
-        runnable.run();
-      } catch (Throwable t) {
-        // ignore
+      synchronized (LogFactory.class) {
+        if (logConstructor == null) {
+          try {
+            runnable.run();
+          } catch (Throwable t) {
+            // ignore
+          }
+        }
       }
     }
   }