Merge pull request #2805 from hogimn/test

Update test code to clarify the consequence
mybatis · Feb 13, 2023 · db754ce · db754ce
2 parents 661e574 + b2bc913
commit db754ce
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/test/java/org/apache/ibatis/executor/BaseExecutorTest.java b/src/test/java/org/apache/ibatis/executor/BaseExecutorTest.java
@@ -253,8 +253,10 @@ void shouldSelectDiscriminatedPost() throws Exception {
       for (Map<String, String> m : products) {
         if ("IMAGES".equals(m.get("SECTION"))) {
           assertNull(m.get("subject"));
+          assertNotNull(m.get("id"));
         } else {
           assertNotNull(m.get("subject"));
+          assertNull(m.get("id"));
         }
       }
     } finally {
@@ -274,8 +276,10 @@ void shouldSelect2DiscriminatedPosts() throws Exception {
       for (Map<String, String> m : products) {
         if ("IMAGES".equals(m.get("SECTION"))) {
           assertNull(m.get("subject"));
+          assertNotNull(m.get("id"));
         } else {
           assertNotNull(m.get("subject"));
+          assertNull(m.get("id"));
         }
       }
     } finally {

diff --git a/src/test/java/org/apache/ibatis/executor/ExecutorTestHelper.java b/src/test/java/org/apache/ibatis/executor/ExecutorTestHelper.java
@@ -305,7 +305,7 @@ static MappedStatement prepareSelectDiscriminatedPost(final Configuration config
                     put("NEWS", discriminatorResultMap.getId());
                     put("VIDEOS", discriminatorResultMap.getId());
                     put("PODCASTS", discriminatorResultMap.getId());
-                    // NEWS left out on purpose.
+                    // IMAGES left out on purpose.
                   }
                 }).build()).build());