ScriptRunnerTest fails on Windows OS

[kazuki43zoo]

The ScriptRunner has code that depends on OS.

mybatis-3/src/main/java/org/apache/ibatis/jdbc/ScriptRunner.java

Line 35 in 2f15fcd

private static final String LINE_SEPARATOR = System.getProperty("line.separator", "\n");

But test case does not consider it.

Error Details

Results :

Failed tests:
  ScriptRunnerTest.shouldAcceptDelimiterVariations:267
Argument(s) are different! Wanted:
statement.execute(
    "line 1;
line 2;

"
);
-> at org.apache.ibatis.jdbc.ScriptRunnerTest.shouldAcceptDelimiterVariations(ScriptRunnerTest.java:267)
Actual invocation has different arguments:
statement.execute(
    "line 1;
line 2;

"
);
-> at org.apache.ibatis.jdbc.ScriptRunner.executeStatement(ScriptRunner.java:247)

  ScriptRunnerTest.shouldAcceptMultiCharDelimiter:301
Argument(s) are different! Wanted:
statement.execute(
    "line 1;
line 2;

"
);
-> at org.apache.ibatis.jdbc.ScriptRunnerTest.shouldAcceptMultiCharDelimiter(ScriptRunnerTest.java:301)
Actual invocation has different arguments:
statement.execute(
    "line 1;
line 2;

"
);
-> at org.apache.ibatis.jdbc.ScriptRunner.executeStatement(ScriptRunner.java:247)

[kazuki43zoo]

@hazendaz I've fixed this on master and 3.4.x. Thanks for your reporting!

[hazendaz]

Great thanks. I'll check it out Get Outlook for Android<https://aka.ms/ghei36>

…

________________________________ From: Kazuki Shimizu <notifications@github.com> Sent: Sunday, March 25, 2018 1:58:50 AM To: mybatis/mybatis-3 Cc: Jeremy Landis; Mention Subject: Re: [mybatis/mybatis-3] ScriptRunnerTest fails on Windows OS (#1230) @hazendaz<https://github.com/hazendaz> I've fixed this on master and 3.4.x. Thanks for your reporting! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#1230 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AA7ho4qVIMsBJ7SwDkeDlc6Zl_T9egwcks5thzIagaJpZM4S598v>.