Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

field id should be final in class org.apache.ibatis.mapping.Environment.Builder #1705

Closed
galleChristian opened this issue Oct 30, 2019 · 1 comment
Assignees
Labels
polishing Improve a implementation code or doc without change in current behavior/content
Milestone

Comments

@galleChristian
Copy link

galleChristian commented Oct 30, 2019

MyBatis version

3.5.3

Database vendor and version

Test case or example project

Steps to reproduce

Expected result

public static class Builder {

    private final String id;

    public Builder(String id) {

      this.id = id;

    }
}

Actual result

public static class Builder {
    private String id;  //  not final
    public Builder(String id) {
      this.id = id;
    }
}
@kazuki43zoo kazuki43zoo self-assigned this Oct 30, 2019
@kazuki43zoo kazuki43zoo added the polishing Improve a implementation code or doc without change in current behavior/content label Oct 30, 2019
@kazuki43zoo kazuki43zoo added this to the 3.5.4 milestone Oct 30, 2019
@kazuki43zoo
Copy link
Member

@galleChristian I've applied your suggestion. Thanks!

pulllock pushed a commit to pulllock/mybatis-3 that referenced this issue Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
polishing Improve a implementation code or doc without change in current behavior/content
Projects
None yet
Development

No branches or pull requests

2 participants