New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset default value of keyProperty. #1198

Merged
merged 2 commits into from Mar 16, 2018

Conversation

Projects
None yet
2 participants
@harawata
Copy link
Member

harawata commented Mar 1, 2018

Current implementation sets "id" as the default value of keyProperty.
But having default value makes it difficult to report helpful errors from Jdbc3KeyGenerator (see #782 and #902).

As it is possible that there are solutions relying on this default value, the target is set to 3.5.0.

Unset default value of keyProperty.
It causes a problem like #902 and makes it difficult to handle errors in Jdbc3KeyGenerator.

@harawata harawata added the enhancement label Mar 1, 2018

@harawata harawata added this to the 3.5.0 milestone Mar 1, 2018

@harawata harawata self-assigned this Mar 1, 2018

@kazuki43zoo

This comment has been minimized.

Copy link
Member

kazuki43zoo commented Mar 16, 2018

+1

@harawata harawata merged commit de9bd7d into mybatis:master Mar 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

kazuki43zoo added a commit that referenced this pull request Apr 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment