Drop support JDK 6 and 7 at build definitions #1209
Conversation
|
@kazuki43zoo Sorry about that. I applied the maven wrapper 0.40 but left as 3.2.5. Can you rebase? |
pom.xml
Outdated
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jboss.spec.javax.transaction</groupId> | ||
| <artifactId>jboss-transaction-api_1.2_spec</artifactId> | ||
| <version>1.0.1.Final</version> | ||
| <version>1.1.1.Final</version> |
There was a problem hiding this comment.
@kazuki43zoo We can use the real one now...
<groupId>javax.transaction</groupId>
<artifactId>javax.transaction-api</artifactId>
<version>1.3</version>
Of course!
OK! I will change to use the |
* log4j-core 2.3 -> 2.5 * cglib 3.2.5 -> 3.2.6 * junit-vintage-engine 4.12.2 -> 5.1.0 * hsqldb 2.3.5 -> 2.4.0 * derby 10.12.1.1 -> 10.14.1.0 * mockito-core 2.12.0 -> 2.16.0 * commons-dbcp 1.x -> commons-dbcp2 2.2.0 * jboss-transaction-api_1.2_spec 1.0.1 -> 1.1.1 * postgresql 42.1.4.jre6 -> 42.2.1 * assertj-core 1.7.1 -> 3.9.1 * catch-exception 1.4.4 -> 1.4.6 * postgresql-embedded 2.5 -> 2.8
kazuki43zoo
force-pushed
the
gh-1207_drop-jdk6_7
branch
from
f24b563
to
b1f9387
Compare
|
@hazendaz I've applied your comments. And I've updated to mybatis-parent 31-SNAPSHOT. |
|
@harawata @jeffgbutler Can I merge this? |
|
I didn't check the details, but I trust you guys. :) |
|
I've merged this at now. If there is a problem, please add a comment. |
|
Looked good to me! Nice work! Java 8 has arrived finally.
Get Outlook for Android<https://aka.ms/ghei36>
…________________________________
From: Kazuki Shimizu <notifications@github.com>
Sent: Monday, March 19, 2018 10:44:20 AM
To: mybatis/mybatis-3
Cc: Jeremy Landis; Mention
Subject: Re: [mybatis/mybatis-3] Drop support JDK 6 and 7 at build definitions (#1209)
I've merged this at now. If there is a problem, please add a comment.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1209 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AA7ho84rb21cKMXbGw_Z7CT0CtLuLDBiks5tf8REgaJpZM4SumH->.
|
| </build> | ||
| </profile> | ||
| </profiles> | ||
| <repositories> |
There was a problem hiding this comment.
This used to work without problems. Anyone know what changed to require this? Do we want to add this to the parent?
There was a problem hiding this comment.
I've added to refer the mybatis-parent 31-SNAPSHOT on travis-ci. (it is temporary solution until releasing mybatis-parent 31).
Do we want to add this to the parent?
No.
There was a problem hiding this comment.
Thanks. I find it odd though that using the snapshots used to work fine on travis. I suspect something changed. I did fully bring the parent up-to-date just a little while ago. I've got some questions in it that I need to answer but likely could get it released out soon.
Drop support JDK 6 and 7 at build definitions
I've fixed #1207 .
Please review this.
Notes:
Following two artifacts could not upgrade to the latest version. Please see the xml's comment about reason. I will create new issues to fix it.
Thanks.