A new type handler for SQLXML data type. #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazuki43zoo
reviewed
Mar 22, 2018
| } | ||
|
|
||
| protected String sqlxmlToString(SQLXML sqlxml) throws SQLException { | ||
| String result = sqlxml.getString(); |
There was a problem hiding this comment.
I think it needs the null check.
| import java.sql.SQLException; | ||
| import java.sql.SQLXML; | ||
|
|
||
| public class SqlxmlTypeHandler extends BaseTypeHandler<String> { |
There was a problem hiding this comment.
Let's add JavaDoc(description, since, author...).
| SQLXML sqlxml = ps.getConnection().createSQLXML(); | ||
| sqlxml.setString(parameter); | ||
| ps.setSQLXML(i, sqlxml); | ||
| sqlxml.free(); |
There was a problem hiding this comment.
If you need to call free(), it may be better to call it in try-finally.
|
Thanks @kazuki43zoo ! |
kazuki43zoo
reviewed
Mar 23, 2018
| /** | ||
| * Convert <code>String</code> to/from <code>SQLXML</code>. | ||
| * | ||
| * @since 3.4.5 |
kazuki43zoo
added a commit
to kazuki43zoo/mybatis-3
that referenced
this pull request
May 3, 2018
kazuki43zoo
added a commit
to kazuki43zoo/mybatis-3
that referenced
this pull request
May 3, 2018
kazuki43zoo
added a commit
that referenced
this pull request
May 3, 2018
|
Thank you for the update, @kazuki43zoo ! |
h3adache
pushed a commit
that referenced
this pull request
May 5, 2018
Requires drivers support JDBC 4.0+.
h3adache
pushed a commit
that referenced
this pull request
May 5, 2018
h3adache
pushed a commit
that referenced
this pull request
May 5, 2018
h3adache
pushed a commit
that referenced
this pull request
May 5, 2018
pulllock
pushed a commit
to pulllock/mybatis-3
that referenced
this pull request
Oct 19, 2023
Requires drivers support JDBC 4.0+.
pulllock
pushed a commit
to pulllock/mybatis-3
that referenced
this pull request
Oct 19, 2023
pulllock
pushed a commit
to pulllock/mybatis-3
that referenced
this pull request
Oct 19, 2023
pulllock
pushed a commit
to pulllock/mybatis-3
that referenced
this pull request
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to be working with...
XMLTYPEcolumn)XMLcolumn)XMLcolumn / mssql-jdbc driver)XMLcolumn / db2jcc4 driver)