XSD support in mapper/config XML (revised) #1531
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass around Resource instead of InputStream/Reader so that XPathParser can re-read the file.
harawata
force-pushed
the
xsd-support-custom-resource
branch
from
c9d56f3
to
c638f66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative approach to fix #1193 .
Unlike the previous PR #1393 , this one does not require any configuration nor switch.
It tries to read using DTD first and if it fails, re-read the same file using XSD.
Note that a caller must pass the new
org.apache.ibatis.io.Resourceobject instead ofReader/InputStreamso that MyBatis can re-read the same file twice.mybatis-spring may need adjustment like this.
@jeffgbutler ,
It is a little bit rough, but should be enough to evaluate the concept.
Please review when you have time!
No rush, of course. :)