-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the description of set tag in dynamic-sql.xml doc #2347
Conversation
Update the description of set tag in dynamic-sql.xml ref: 95166a6#diff-df20f6a8f86025feb42cead35070d7689a4f04afc051008c93a2f38250bf53afR31
Thank you for the PR, @xtyuns ! Usually, you only need |
Hi @harawata, I understand what you mean, but what I pointed out is about the replacement of set tags and trim tags. mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/SetSqlNode.java Lines 26 to 34 in 0e20200
Because I encountered some problems in the process of using MyBatis, so I like to point out the errors in the documentation. |
Hi @xtyuns , I see. I am OK with rephrasing the sentence. For example:
I just don't think specifying both I have reopened the PR, so you can add or force-push new commits to the same branch (patch-1). Thank you! |
Ok, I open a new PR, so I closed this one. |
in the fact,
<set>
is equal to<trim prefix="set" prefixOverrides="," suffixOverrides=",">
ref: 95166a6#diff-df20f6a8f86025feb42cead35070d7689a4f04afc051008c93a2f38250bf53afR31