Skip to content

Commit

Permalink
[pom] Add property declaring Automatic-Module-Name
Browse files Browse the repository at this point in the history
  • Loading branch information
harawata committed Dec 30, 2018
1 parent 3b1df14 commit 3377f93
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
<junit.jupiter.version>5.3.2</junit.jupiter.version>
<junit.platform.version>1.3.2</junit.platform.version>
<clirr.comparisonVersion>1.1.0</clirr.comparisonVersion>
<module.name>org.mybatis.dynamic.sql</module.name>
</properties>

<build>
Expand Down

3 comments on commit 3377f93

@harawata
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffgbutler @hazendaz @kazuki43zoo
Replacing hyphens with dots seems popular, but it feels a little bit weird.
Should it be org.mybatis.dynamicsql ?

@hazendaz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sort of thought this naming convention aligned with the underlying packaging so what you have already on line 39 matches.

@harawata
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK! Thanks @hazendaz !

Please sign in to comment.