-
Notifications
You must be signed in to change notification settings - Fork 219
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ssl/format] Tabs to spaces and add new ssl params for redis 2.9.0
- Loading branch information
Showing
6 changed files
with
240 additions
and
195 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,5 +19,5 @@ | |
|
||
public interface RedisCallback { | ||
|
||
Object doWithRedis(Jedis jedis); | ||
Object doWithRedis(Jedis jedis); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
e7d4f07
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new options are not simple types and RedisConfigurationBuilder throws an exception if they are specified.
The test is passing on Travis maybe because the configuration file is not correctly picked up?
e7d4f07
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harawata hmmm...I agree they are complex types. I don't have redis locally to test. Travis CI appears to be working. It says all 6 tests ran. Maybe because I left all values in test as null? In your testing, did you run as-is or specifiy values? I'm sure this is now a bug, basically supporting 2.9.x but not working as one would expect.
e7d4f07
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harawata I'm wondering if we can the settings on this for the complex types. Looking at just hostnameVerifier, jedis is internally creating one here. Basically they do it all so wonder if that is a good enough approach for now so it's at least supported at a basic level. I otherwise know zero with redis in general as I've never used it.
e7d4f07
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hazendaz
as-is. The test passes if 1) the config file does not exist or 2) the new keys don't exist in the file, so I suspected that Travis couldn't see the file for some reason.
Anyway, basic level support should be fine while it's in beta.
e7d4f07
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, I just started to see if it's possible to add the frequently-requested 'flushInterval' option.
e7d4f07
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harawata So I have something mostly picked from redis tests. It needs the peer certificates to get loaded before it might work. Not the best solution but probably a good starting point here
e7d4f07
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, @hazendaz !
I don't have Redis + SSL setup to try the change, unfortunately.
We may have to release beta3 with it and wait for a feedback from users who actually use this feature, I guess.
e7d4f07
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e7d4f07
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to release b3 if SSL stuff is not ready yet. Let's keep it as a SNAPSHOT for now.
e7d4f07
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.