Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of NestedIOException. #663

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Remove usage of NestedIOException. #663

merged 1 commit into from
Apr 13, 2022

Conversation

schauder
Copy link
Contributor

NestedIOException was removed from Spring Framework with spring-projects/spring-framework@2fb1dd1

@schauder
Remove usage of NestedIOException.
30b395a 
NestedIOException was removed from Spring Framework with spring-projects/spring-framework@2fb1dd1
@schauder
Copy link
Contributor Author

This issue breaks Spring Data JDBCs integration in version 3.0 which is based on Spring Framework 6.0 which includes the commit mentioned above. It therefore would be cool, if we could get a release containing this change.

@kazuki43zoo kazuki43zoo self-assigned this Apr 13, 2022
@kazuki43zoo kazuki43zoo added this to the 2.1.0 milestone Apr 13, 2022
@kazuki43zoo
Copy link
Member

@schauder Thanks for your contributing!! I will merging at later.

@kazuki43zoo kazuki43zoo added enhancement Improve a feature or add a new feature no backward compatibility Includes change no backward compatibility for previous version labels Apr 13, 2022
@kazuki43zoo kazuki43zoo merged commit 819a8f5 into mybatis:master Apr 13, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.314% when pulling 30b395a on schauder:master into c22d368 on mybatis:master.

@kazuki43zoo
Copy link
Member

@schauder I've published the 2.1.0-SNAPSHOT on OSS sonatype repository.

@schauder
Copy link
Contributor Author

Thanks.

@schauder schauder mentioned this pull request Apr 19, 2022
Closed
schauder added a commit to spring-projects/spring-data-relational that referenced this pull request Apr 19, 2022
@schauder
Upgrade Mybatis Spring Version to 2.1.0-SNAPSHOT
68df072 
This fixes the current build problems, which are caused by removal of NestedIOException from Spring Framework.

Closes #1218
See mybatis/spring#663
schauder added a commit to spring-projects/spring-data-relational that referenced this pull request Apr 19, 2022
@schauder
Upgrade Mybatis Spring Version to 2.1.0-SNAPSHOT
0ac8aa8 
This fixes the current build problems, which are caused by removal of NestedIOException from Spring Framework.

Closes #1218
See mybatis/spring#663
@schauder
Copy link
Contributor Author

Would you be able to release at least a milestone release until Thursday? Wednesday Spring Framework probably releases their new milestone, and on Friday Spring Data is planning to release their next milestone and we can't/ don't want to depend on a snapshot for that release.

Our alternative would be to revert back to the last GA release in Spring Data and ask users to consider switch to the snapshot.

@kazuki43zoo
Copy link
Member

@schauder I will propose releasing 2.1.0 to owners.

@ruanych ruanych mentioned this pull request Jun 1, 2022
Closed
xuxiaowei-com-cn added a commit to xuxiaowei-cloud/xuxiaowei-cloud-next that referenced this pull request Jul 7, 2022
@xuxiaowei-com-cn
🐛 使用 org.mybatis.spring.boot:mybatis-spring-boot-starter 快照版，解决打包后出现不…
bec46c3 
…存在 org.springframework.core.NestedIOException 的异常 #I5G0UQ

移除 org.springframework.core.NestedIOException 议题：mybatis/spring#663
xuxiaowei-com-cn added a commit to xuxiaowei-cloud/xuxiaowei-cloud-next that referenced this pull request Jul 7, 2022
@xuxiaowei-com-cn
🐛 重写 com.baomidou.mybatisplus.extension.spring.MybatisSqlSessionFacto…
521b976 
…ryBean，移除 spring 6.0 中不存在的 org.springframework.core.NestedIOException

移除 org.springframework.core.NestedIOException 议题：mybatis/spring#663
xuxiaowei-com-cn added a commit to xuxiaowei-cloud/xuxiaowei-cloud-next that referenced this pull request Jul 13, 2022
@xuxiaowei-com-cn
🐛 重写 com.baomidou.mybatisplus.extension.spring.MybatisSqlSessionFacto…
58e6844 
…ryBean，移除 spring 6.0 中不存在的 org.springframework.core.NestedIOException

移除 org.springframework.core.NestedIOException 议题：mybatis/spring#663
@kazuki43zoo
Copy link
Member

Hi @schauder , We published the 3.0.0-SNAPSHOT for supporting Spring 6 and Spring Batch 5 (Because the API specification of Spring Batch 5 does not keep backward-compatibility for Spring Batch 4).

@schauder
Copy link
Contributor Author

Das that mean a GA release with a fix for this issue will only become available after Spring Batch 5 is available?

@kazuki43zoo
Copy link
Member

kazuki43zoo commented Sep 25, 2022 •
edited
Loading

@schauder
This change will be included in 2.1.0 too, which is scheduled for release in early October, but the version that officially supports Spring 6 and Spring Batch 5 will be the mybatis-spring 3.0. The mybatis-spring 3.0 will release after Spring 6 and Spring Batch 5 GA version released.

@schauder
Copy link
Contributor Author

Any news about the 2.1.0 release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kazuki43zoo kazuki43zoo

Labels
enhancement Improve a feature or add a new feature no backward compatibility Includes change no backward compatibility for previous version
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@schauder @kazuki43zoo @coveralls