Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_encoding() can cause timeouts #112

Closed
JN-Jones opened this issue Sep 9, 2014 · 0 comments
Closed

check_encoding() can cause timeouts #112

JN-Jones opened this issue Sep 9, 2014 · 0 comments
Assignees
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:enhancement Type: Enhancement. Contains minor improvements
Milestone

Comments

@JN-Jones
Copy link
Contributor

JN-Jones commented Sep 9, 2014

The functions checks already the length of the string:

// These functions can have significant load or crash if the string passed is too long.
if(strlen($string) < 1024*5)

However this may also happen with short strings so I'll add a global constant to deactivate that check.

@JN-Jones JN-Jones added t:enhancement Type: Enhancement. Contains minor improvements b:1.8 Branch: 1.8.x labels Sep 9, 2014
@JN-Jones JN-Jones added this to the 1.8.0 milestone Sep 9, 2014
@JN-Jones JN-Jones self-assigned this Sep 9, 2014
JN-Jones added a commit that referenced this issue Sep 9, 2014
Fixes #112 check_encoding() can cause timeouts
@JN-Jones JN-Jones added the s:resolved Status: Resolved. Solution implemented or scheduled label Sep 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:enhancement Type: Enhancement. Contains minor improvements
Projects
None yet
Development

No branches or pull requests

1 participant