Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread prefix error #1247

Closed
DiogoParrinha opened this issue Aug 17, 2014 · 4 comments · Fixed by #1252
Closed

Thread prefix error #1247

DiogoParrinha opened this issue Aug 17, 2014 · 4 comments · Fixed by #1252
Assignees
@Sama34
Labels
b:1.8 Branch: 1.8.x p:low Priority: Low. Issue to resolve with low preference s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Milestone
1.8.0

Comments

@DiogoParrinha
Copy link
Contributor

[attachment=32192]
The error occurred after i posted a message in a forum that requires a thread prefix .
but i have no thread prefixes setted up yet .

i have the latest mybb 1.8 from github

Original thread: Thread prefix error
@DiogoParrinha DiogoParrinha added this to the 1.8.1 milestone Aug 17, 2014
@DiogoParrinha
Copy link
Contributor Author

Should be a matter of checking if the array is empty before going through a foreach.

@Sama34 Sama34 self-assigned this Aug 17, 2014
@Sama34 Sama34 mentioned this issue Aug 17, 2014
Merged
@Sama34 Sama34 added the s:fixed label Aug 17, 2014
@Sama34
Copy link
Contributor

Sama34 commented Aug 17, 2014

Didn't notice this was set for 1.8.1... lol?

@Destroy666x Destroy666x modified the milestones: 1.8.1, 1.8.0 Aug 18, 2014
@DiogoParrinha
Copy link
Contributor Author

Yes it was, we need to manage priorities now. But as you fixed, no worries :P

Starpaul20 added a commit that referenced this issue Aug 19, 2014
@Starpaul20
Merge pull request #1252 from Sama34/fix-1247
6ba34f4 
Fixes #1247 Thread prefix error
@Starpaul20
Copy link
Member

Merged PR, looking good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sama34 Sama34

Labels
b:1.8 Branch: 1.8.x p:low Priority: Low. Issue to resolve with low preference s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Projects
None yet
Milestone
1.8.0
Development

Successfully merging a pull request may close this issue.

Fixes #1247 Thread prefix error
4 participants
@DiogoParrinha @Starpaul20 @Sama34 @Destroy666x