Account awaiting activation notification settings

[Sama34]

The notification bar should have some settings or be affected by current ones.

• Turn on/off setting.
• ACP link?

Reference: http://community.mybb.com/thread-158427.html

[DiogoParrinha]

@JordanMussi @JN-Jones @darkmew @ImadJomaa

[Stefan-MyBB]

@Sama34 We can't merge your pull request.

[Eldenroot]

@Sama34 - could you make a new PR?

In my opinion "Turn on/off setting" is a must have function, it would be nice to have it in 1.8.4 because many users complain about it in forum :(

[DiogoParrinha]

@Sama34 your PR has dozens of changes. Any idea why? 99% don't affect this.

[Sama34]

I'm not sure, I can't fix it so as already mentioned in the PR I need #1389 to work on this and other issues.

[Sama34]

I added a new PR.

[Destroy666x]

It fixes the 1st checkbox, what about the other 2?

[Sama34]

I can't recall why I didn't fixed those. I can't even recall what the acp link one is about, lol

[Destroy666x]

It's about turning the notification (or a part of it) into a link to ACP page with a list of unactivated accounts:
admin/index.php?module=user-users&action=search&results=1&conditions=a%3A1%3A%7Bs%3A9%3A"usergroup"%3Bs%3A1%3A"5"%3B%7D
So a quite easy task.

Not sure if the 3rd checkbox is needed after an additional setting for the notification was added. I wouldn't change that, admins can simply turn off the bar if they use a different registration method or leave it on if they still want it.

[Sama34]

That link is quite different from the one shown in the ACP home page /index.php?module=user-users&action=search&results=1&conditions=a%3A1%3A%7Bs%3A9%3A%22usergroup%22%3Bs%3A1%3A%225%22%3B%7D&from=home. I have committed the change though.

[Destroy666x]

I don't see any difference except the &from=home at the end, which only tells that you jumped to that page from the ACP index. And the " are encoded (should be encoded in the core file too and & changed to &).

[Sama34]

I moved the link to the language file since it is more accessible for administrators to edit it there (for whatever reason). I also encoded the &'s.