Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate update_password #1760

Closed
Sama34 opened this issue Jan 16, 2015 · 2 comments · Fixed by #1850
Closed

Deprecate update_password #1760

Sama34 opened this issue Jan 16, 2015 · 2 comments · Fixed by #1850
Assignees
@Sama34
Labels
b:1.8 Branch: 1.8.x p:low Priority: Low. Issue to resolve with low preference s:feedback Status: Feedback. Further information/input needed t:enhancement Type: Enhancement. Contains minor improvements
Milestone
1.8.8

Comments

@Sama34
Copy link
Contributor

Sama34 commented Jan 16, 2015

MyBB has update_password in ./inc/functions_user.php, which is only used to update a user's password when it is reset.

This should be deprecated and the user datahandler should be used instead, as is standard elsewhere in MyBB where user fields are updated.

http://community.mybb.com/thread-165506.html
@Sama34 Sama34 added t:enhancement Type: Enhancement. Contains minor improvements b:1.8 Branch: 1.8.x s:feedback Status: Feedback. Further information/input needed p:low Priority: Low. Issue to resolve with low preference labels Jan 16, 2015
@Sama34 Sama34 self-assigned this Jan 16, 2015
@Sama34 Sama34 added this to the 1.8.5 milestone Jan 16, 2015
@tommm
Copy link
Member

tommm commented Jan 16, 2015

@Sama34 do you intend to work on this?

@Sama34
Copy link
Contributor Author

Sama34 commented Jan 17, 2015

Feel free to work on it if you please to, I will finish all of my 1.8.4 milestone issues before working on any other (1.8.5).

If you don't, then yes I will.

@Sama34 Sama34 mentioned this issue Feb 18, 2015
Merged
@Sama34 Sama34 added s:resolved Status: Resolved. Solution implemented or scheduled and removed s:feedback Status: Feedback. Further information/input needed labels Feb 18, 2015
@JN-Jones JN-Jones modified the milestones: 1.8.5, 1.8.6 Apr 30, 2015
@JN-Jones JN-Jones added s:feedback Status: Feedback. Further information/input needed and removed s:resolved Status: Resolved. Solution implemented or scheduled labels Jun 22, 2015
@JN-Jones JN-Jones modified the milestones: 1.8.6, 1.8.7 Aug 26, 2015
@Stefan-MyBB Stefan-MyBB modified the milestones: 1.8.7, 1.8.8 Mar 2, 2016
dequeues pushed a commit that referenced this issue Jun 3, 2016
@Sama34 @dequeues
Fix #1760 Deprecate update_password (#1850)
37ac816 
* Fix #1760 Deprecate update_password

* Update deprecation message

* Fix stuff

* Fix indendation

* Fix indendation 2

* Fix deprecate block notice

* Update to #1868

* Use while loop

* Remove lang string

* Use full path on require_once

* Fix validation errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sama34 Sama34

Labels
b:1.8 Branch: 1.8.x p:low Priority: Low. Issue to resolve with low preference s:feedback Status: Feedback. Further information/input needed t:enhancement Type: Enhancement. Contains minor improvements
Projects
None yet
Milestone
1.8.8
Development

Successfully merging a pull request may close this issue.

Fix #1760 Deprecate update_password
4 participants
@tommm @Stefan-MyBB @Sama34 @JN-Jones