Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Very inefficient managegroups.php code... #1816

Closed
Destroy666x opened this issue Feb 7, 2015 · 0 comments · Fixed by #2014
Closed

Very inefficient managegroups.php code... #1816

Destroy666x opened this issue Feb 7, 2015 · 0 comments · Fixed by #2014
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Milestone
1.8.6

Comments

@Destroy666x
Copy link
Contributor

https://github.com/mybb/mybb/blob/feature/managegroup.php#L376 - that's quite bad, one query is executed per every group member while the leaders could be simply added to an array in this loop: https://github.com/mybb/mybb/blob/feature/managegroup.php#L307 and then checked with in_array().
@Destroy666x Destroy666x added t:bug Type: Bug. An issue causing error / flaw / malfunction s:confirmed Status: Confirmed. Retested and found the issue exists b:1.8 Branch: 1.8.x p:medium Priority: Medium. Issues to be resolved with normal preference labels Feb 7, 2015
@Destroy666x Destroy666x self-assigned this Feb 7, 2015
@Destroy666x Destroy666x added this to the 1.8.5 milestone Feb 7, 2015
@JN-Jones JN-Jones modified the milestones: 1.8.5, 1.8.6 Apr 30, 2015
@Krytic Krytic mentioned this issue Jun 2, 2015
Merged
@Destroy666x Destroy666x removed their assignment Jun 2, 2015
@Destroy666x Destroy666x added s:in-progress Status: In Progress. Some work completed and removed s:confirmed Status: Confirmed. Retested and found the issue exists labels Jun 2, 2015
Destroy666x added a commit that referenced this issue Jun 4, 2015
@Destroy666x
Merge pull request #2014 from Krytic/fix-1816
d9a41f3 
Fix #1816 (Very inefficient managegroups.php code)
@Destroy666x Destroy666x added s:resolved Status: Resolved. Solution implemented or scheduled and removed p:medium Priority: Medium. Issues to be resolved with normal preference s:in-progress Status: In Progress. Some work completed labels Jun 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Projects
None yet
Milestone
1.8.6
Development

Successfully merging a pull request may close this issue.

Fix #1816 (Very inefficient managegroups.php code)
2 participants
@JN-Jones @Destroy666x