Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saving draft changes thread icon to replied in search page #1869

Closed
Destroy666x opened this issue Feb 19, 2015 · 0 comments · Fixed by #1881
Closed

Saving draft changes thread icon to replied in search page #1869

Destroy666x opened this issue Feb 19, 2015 · 0 comments · Fixed by #1881
Assignees
@Sama34
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Milestone
1.8.5

Comments

@Destroy666x
Copy link
Contributor

i am yet to check whether its a bug or just a issue on this community, so posting in site issues section...

when you try to reply to any thread and save draft of the reply, the thread icon changes to the one for "Contains Posts by You" although we haven't replied to that thread... this happens only in the search page, if we look at the forumdisplay it shows the right icon...

check below images where the 1st one from search page and the second from forumdisplay....

Original thread: Saving draft changes thread icon to replied in search page

EDIT: forumdisplay checks $visibleonly and search doesn't seem to.
https://github.com/mybb/mybb/blob/feature/forumdisplay.php#L930
https://github.com/mybb/mybb/blob/feature/search.php#L362
https://github.com/mybb/mybb/blob/feature/search.php#L783
@Destroy666x Destroy666x added t:bug Type: Bug. An issue causing error / flaw / malfunction s:confirmed Status: Confirmed. Retested and found the issue exists b:1.8 Branch: 1.8.x labels Feb 19, 2015
@Destroy666x Destroy666x added this to the 1.8.5 milestone Feb 19, 2015
@Sama34 Sama34 self-assigned this Feb 20, 2015
@Sama34 Sama34 mentioned this issue Feb 21, 2015
Merged
@Sama34 Sama34 added s:resolved Status: Resolved. Solution implemented or scheduled and removed s:confirmed Status: Confirmed. Retested and found the issue exists labels Feb 21, 2015
Stefan-MyBB pushed a commit that referenced this issue Mar 17, 2015
@stefan-st
Merge pull request #1881 from Sama34/fix-1869
d10a94e 
Fix #1869 Saving draft changes thread icon to replied in search page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sama34 Sama34

Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Projects
None yet
Milestone
1.8.5
Development

Successfully merging a pull request may close this issue.

Fix #1869 Saving draft changes thread icon to replied in search page
2 participants
@Sama34 @Destroy666x