Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URLs never shortened #1995

Closed
Destroy666x opened this issue May 24, 2015 · 0 comments
Closed

URLs never shortened #1995

Destroy666x opened this issue May 24, 2015 · 0 comments
Assignees
@Destroy666x
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Milestone
1.8.5

Comments

@Destroy666x
Copy link
Contributor

http://community.mybb.com/thread-170981-post-1159249.html#pid1159249

So the !empty() change for shorten_urls option is wrong because it was supposed to be the other way round - URLs shouldn't be shortened only when the option is set to 0 in one place - printthread.php

Not sure why the change was made in the 1st place, earlier code doesn't throw any notice due to !isset() check.
@Destroy666x Destroy666x added t:bug Type: Bug. An issue causing error / flaw / malfunction b:1.8 Branch: 1.8.x s:in-progress Status: In Progress. Some work completed p:medium Priority: Medium. Issues to be resolved with normal preference labels May 24, 2015
@Destroy666x Destroy666x self-assigned this May 24, 2015
@Destroy666x Destroy666x added this to the 1.8.6 milestone May 24, 2015
@Destroy666x Destroy666x mentioned this issue May 24, 2015
Merged
@Destroy666x Destroy666x added s:resolved Status: Resolved. Solution implemented or scheduled and removed p:medium Priority: Medium. Issues to be resolved with normal preference s:in-progress Status: In Progress. Some work completed labels May 24, 2015
ATofighi added a commit that referenced this issue May 24, 2015
@ATofighi
Merge pull request #1996 from Destroy666x/fix1995
2f45d64 
Fix #1995 URLs not shortened at all
@ATofighi ATofighi modified the milestones: 1.8.5, 1.8.6 May 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Destroy666x Destroy666x

Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Projects
None yet
Milestone
1.8.5
Development

No branches or pull requests
2 participants
@ATofighi @Destroy666x