Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usercp_avatar HTML syntax error. #2076

Closed
JN-Jones opened this issue Jun 25, 2015 · 0 comments
Closed

usercp_avatar HTML syntax error. #2076

JN-Jones opened this issue Jun 25, 2015 · 0 comments
Assignees
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Milestone

Comments

@JN-Jones
Copy link
Contributor

The usercp_avatar seems to be wrong:

Code:
<html>
<head>
<title>{$mybb->settings['bbname']} - {$lang->change_avatar}</title>
{$headerinclude}
</head>
<body>
{$header}
<table width="100%" border="0" align="center">
<tr>
    {$usercpnav}
    <td valign="top">
        {$avatar_error}
        <table border="0" cellspacing="{$theme['borderwidth']}" cellpadding="{$theme['tablespace']}" class="tborder">
            <tr>
                <td class="thead" colspan="2"><strong>{$lang->change_avatar}</strong></td>
            </tr>
            <tr>
                <td class="trow1" colspan="2">
                    <table cellspacing="0" cellpadding="0" width="100%">
                        <tr>
                            <td>{$lang->avatar_note}{$avatarmsg}</td>
                            {$currentavatar}
                        </tr>
                    </table>
                </td>
            </tr>
            <tr>
                <td class="tcat" colspan="2"><strong>{$lang->custom_avatar}</strong></td>
            </tr>
            <form enctype="multipart/form-data" action="usercp.php" method="post">
            <input type="hidden" name="my_post_key" value="{$mybb->post_code}" />
            {$avatarupload}
            <tr>
                <td class="trow2" width="40%">
                    <strong>{$lang->avatar_url}</strong>
                    <br /><span class="smalltext">{$lang->avatar_url_note}</span>
                </td>
                <td class="trow2" width="60%">
                    <input type="text" class="textbox" name="avatarurl" size="45" value="{$avatarurl}" />
                    <br /><span class="smalltext">{$lang->avatar_url_gravatar}</span>
                </td>
            </tr>
        </table>

        <br />
        <div align="center">
            <input type="hidden" name="action" value="do_avatar" />
            <input type="submit" class="button" name="submit" value="{$lang->change_avatar}" />
            {$removeavatar}
        </div>
    </td>
</tr>
</table>
</form>
{$footer}
</body>
</html>

The form tags are not correctly placed.

Original thread: usercp_avatar HTML syntax error.

@JN-Jones JN-Jones added t:bug Type: Bug. An issue causing error / flaw / malfunction s:confirmed Status: Confirmed. Retested and found the issue exists b:1.8 Branch: 1.8.x labels Jun 25, 2015
@JN-Jones JN-Jones added this to the 1.8.6 milestone Jun 25, 2015
@Destroy666x Destroy666x added the p:low Priority: Low. Issue to resolve with low preference label Jun 25, 2015
@JN-Jones JN-Jones self-assigned this Jul 16, 2015
@JN-Jones JN-Jones added s:resolved Status: Resolved. Solution implemented or scheduled and removed s:confirmed Status: Confirmed. Retested and found the issue exists labels Jul 16, 2015
Destroy666x added a commit that referenced this issue Jul 23, 2015
Fixes #2076 usercp_avatar HTML syntax error.
@Destroy666x Destroy666x removed the p:low Priority: Low. Issue to resolve with low preference label Jul 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Projects
None yet
Development

No branches or pull requests

2 participants