Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Click and Hold erases thread prefix in 1.8.6 #2203

Closed
wizard974 opened this issue Sep 18, 2015 · 2 comments
Closed

Click and Hold erases thread prefix in 1.8.6 #2203

wizard974 opened this issue Sep 18, 2015 · 2 comments
Assignees
@Starpaul20
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Milestone
1.8.7

Comments

@wizard974
Copy link

After upgrading mybb 1.8.5 to 1.8.6

Steps to reproduce :

  1. Add a prefix to a thread title
  2. Modify this title with click and hold functionnality
  3. Refresh the page

The prefix disappears.
@wizard974 wizard974 changed the title Click and hold erases thread prefix in 1.8.6 Click and Hold erases thread prefix in 1.8.6 Sep 18, 2015
@Destroy666x Destroy666x added t:bug Type: Bug. An issue causing error / flaw / malfunction s:confirmed Status: Confirmed. Retested and found the issue exists b:1.8 Branch: 1.8.x p:medium Priority: Medium. Issues to be resolved with normal preference labels Sep 18, 2015
@Destroy666x Destroy666x added this to the 1.8.7 milestone Sep 18, 2015
@Destroy666x
Copy link
Contributor

I can confirm. Most likely the same code needs to be added: #2188 More places that use posthandler to update the first post should also be checked for the lack of prefix, if there are any.

https://github.com/mybb/mybb/blob/feature/xmlhttp.php#L390

@Starpaul20 Starpaul20 self-assigned this Sep 18, 2015
@Starpaul20 Starpaul20 mentioned this issue Sep 18, 2015
Merged
@Stefan-MyBB Stefan-MyBB added s:resolved Status: Resolved. Solution implemented or scheduled and removed s:confirmed Status: Confirmed. Retested and found the issue exists labels Oct 29, 2015
@Eldenroot
Copy link
Contributor

@PaulBender would be nice to see in 1.8.7 because it is annoying

Stefan-MyBB pushed a commit that referenced this issue Jan 29, 2016
@stefan-st
Merge pull request #2204 from PaulBender/fix-2203
0aa7736 
Fixes #2203 Click and Hold erases thread prefix in 1.8.6
@Destroy666x Destroy666x removed the p:medium Priority: Medium. Issues to be resolved with normal preference label Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Starpaul20 Starpaul20

Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Projects
None yet
Milestone
1.8.7
Development

No branches or pull requests
5 participants
@Stefan-MyBB @Eldenroot @Starpaul20 @Destroy666x @wizard974