My Alerts wysiwyg editor not shaded on alerts pop-up

[euantorano]

When you're on a page with the wysiwyg editor and click on "View Alerts", the alerts pop up and it gets highlighted, while the background becomes shaded (totally fine so far). but then the wysiwyg editor is not shaded, its still lighted.

Screenshot: http://image.prntscr.com/image/e715f667f90b41aeb22f752c2b2b9c44.png

Original thread: My Alerts wysiwyg editor not shaded on alerts pop-up

[Destroy666x]

Is this surely in the correct place? Modals have a high z-index by default, which seems to shade it.

[euantorano]

@Destroy666x I was talking about this on Slack last night. MyAlerts by default uses MyBB's built in modals. I tested on a near stock forum and the MyAlerts modal was given a z-index of 2, the mask was given 1, and the editor was given 3.

My test board is using the old approach of using rel="modal" rather than an onclick handler though, so I need to update the templates there to use onclick the same as the buddylist does in the standard theme. Once I've checked that, I can either confirm or close this issue.

[Destroy666x]

It'll definitely work with the same onclick because our wrapper function takes care of it: https://github.com/mybb/mybb/blob/feature/jscripts/general.js#L75. As for fixing the rel method, we could do it by extending $.modal, but MyBB.popupWindow() should be used as a standard by devs IMO.

[euantorano]

Alright, it's probably easiest to leave it as is then. I'd rather not go extending/patching third party stuff for 1.8.8.

[ghost]

Why was this rejected so? @euantorano already provided a fix for it, editing the myalerts_headericon template and having the latests alert.php file installed on the server.

[Destroy666x]

Umm... You kind of answered yourself. This is not MyAlerts repository.

[ghost]

Oh ok, why was it posted here anyway then. :P