Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to set cookies with Secure flag #2464

Closed
dvz opened this issue Aug 28, 2016 · 3 comments
Closed

Add option to set cookies with Secure flag #2464

dvz opened this issue Aug 28, 2016 · 3 comments
Assignees
@dvz
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:enhancement Type: Enhancement. Contains minor improvements
Milestone
1.8.10

Comments

@dvz
Copy link
Contributor

dvz commented Aug 28, 2016

Server: https://github.com/mybb/mybb/blob/mybb_1807/inc/functions.php#L1810
Client: https://github.com/mybb/mybb/blob/mybb_1807/jscripts/general.js#L483

as suggested in https://community.mybb.com/thread-198899.html
@dvz dvz added t:enhancement Type: Enhancement. Contains minor improvements b:1.8 Branch: 1.8.x p:medium Priority: Medium. Issues to be resolved with normal preference labels Aug 28, 2016
@dvz dvz added this to the 1.8.8 milestone Aug 28, 2016
@andrewjs18
Copy link
Contributor

I imagine this would cover this line as well? https://github.com/mybb/mybb/blob/mybb_1807/inc/functions.php#L1856

I modified that line to read as:

$cookie .= "; Secure";

@dvz
Copy link
Contributor Author

dvz commented Aug 28, 2016

Yes, though cookies set with JavaScript wouldn't have this attribute.
The Secure flag would be added in similar fashion, depending on a setting.

@Stefan-MyBB Stefan-MyBB modified the milestones: 1.8.8, 1.8.9 Aug 31, 2016
@dvz dvz self-assigned this Sep 8, 2016
@dvz dvz mentioned this issue Sep 8, 2016
Merged
@dvz dvz added s:resolved Status: Resolved. Solution implemented or scheduled and removed p:medium Priority: Medium. Issues to be resolved with normal preference labels Sep 8, 2016
@dvz dvz mentioned this issue Nov 21, 2016
Closed
@dvz
Copy link
Contributor Author

dvz commented Dec 21, 2016

The headerinclude template version was not updated for https://github.com/mybb/mybb/pull/2468/files#diff-05b404fc75b0e5bd6d57c79b667b44b8

@dvz dvz reopened this Dec 21, 2016
@dvz dvz added p:high Priority: High. To resolve with high preference and removed s:resolved Status: Resolved. Solution implemented or scheduled labels Dec 21, 2016
@dvz dvz modified the milestones: 1.8.10, 1.8.9 Dec 21, 2016
@Eldenroot Eldenroot mentioned this issue Dec 22, 2016
Closed
dvz added a commit to dvz/mybb that referenced this issue Dec 23, 2016
@dvz
mybb#2464-related patches
58f9210
@dvz dvz mentioned this issue Dec 23, 2016
Merged
dvz added a commit that referenced this issue Dec 26, 2016
@dvz
#2464-related patches (#2579)
bbff412 
* #2464-related patches

* JS comparison fixes
@Stefan-MyBB Stefan-MyBB modified the milestones: 1.8.10, 1.8.11 Jan 8, 2017
@Stefan-MyBB Stefan-MyBB modified the milestones: 1.8.10, 1.8.11 Jan 8, 2017
@dvz dvz added s:resolved Status: Resolved. Solution implemented or scheduled and removed p:high Priority: High. To resolve with high preference labels Jan 8, 2017
dvz added a commit to dvz/mybb that referenced this issue Jan 8, 2017
@dvz
Bump version numbers to 1.8.10 for mybb#2464 issues
e92fde4
@dvz dvz mentioned this issue Jan 8, 2017
Merged
euantorano pushed a commit that referenced this issue Jan 8, 2017
@dvz @euantorano
#2464-related version bumps & 1.8.9 upgrade file (#2605)
fc852e6 
* Bump version numbers to 1.8.10 for #2464 issues

* Create 1.8.9 upgrade file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dvz dvz

Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:enhancement Type: Enhancement. Contains minor improvements
Projects
None yet
Milestone
1.8.10
Development

No branches or pull requests
3 participants
@Stefan-MyBB @andrewjs18 @dvz