Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delayed moderation - missing lang string for time #2497

Closed
Eldenroot opened this issue Nov 8, 2016 · 2 comments
Closed

Delayed moderation - missing lang string for time #2497

Eldenroot opened this issue Nov 8, 2016 · 2 comments
Labels
b:1.8 Branch: 1.8.x p:medium Priority: Medium. Issues to be resolved with normal preference s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Milestone
1.8.9

Comments

@Eldenroot
Copy link
Contributor

Eldenroot commented Nov 8, 2016 •
edited

https://community.mybb.com/thread-203431.html

Anyway. the lang string is here... am I right?
https://github.com/mybb/mybb/blob/feature/install/resources/mybb_theme.xml#L8010
@JN-Jones
Copy link
Contributor

JN-Jones commented Nov 9, 2016

The language string is only defined in modcp.lang.php which isn't loaded in moderation.php.

Anyways I'd prefer if you don't create issues for reports which hasn't been looked at by a team member. It's a lot easier for us if we can sort them first and push them using our tools instead of cleaning up behind you.

@JN-Jones JN-Jones added b:1.8 Branch: 1.8.x t:bug Type: Bug. An issue causing error / flaw / malfunction p:medium Priority: Medium. Issues to be resolved with normal preference s:confirmed Status: Confirmed. Retested and found the issue exists labels Nov 9, 2016
@JN-Jones JN-Jones added this to the 1.8.9 milestone Nov 9, 2016
@Eldenroot
Copy link
Contributor Author

@JN-Jones - there are over 3 pages of bugs report - many of then from 2014 - it would be nice if you can push/close/reject them... no offence, just my 0.02$

@Eldenroot Eldenroot mentioned this issue Nov 23, 2016
Merged
JN-Jones added a commit that referenced this issue Dec 1, 2016
@JN-Jones
Merge pull request #2527 from Cu8eeeR/Fixes-2497
2a35baf 
Fixes #2497 - Missing lang string for "time" in moderation
@effone effone added s:resolved Status: Resolved. Solution implemented or scheduled and removed s:confirmed Status: Confirmed. Retested and found the issue exists labels May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
b:1.8 Branch: 1.8.x p:medium Priority: Medium. Issues to be resolved with normal preference s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Projects
None yet
Milestone
1.8.9
Development

No branches or pull requests
3 participants
@Eldenroot @JN-Jones @effone