Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Counting of non-countable objects emits Warning on PHP 7.2 #2824

Closed
dvz opened this issue Aug 10, 2017 · 1 comment
Closed

Counting of non-countable objects emits Warning on PHP 7.2 #2824

dvz opened this issue Aug 10, 2017 · 1 comment
Labels
b:1.8 Branch: 1.8.x p:high Priority: High. To resolve with high preference s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Milestone
1.8.13

Comments

@dvz
Copy link
Contributor

dvz commented Aug 10, 2017

https://github.com/mybb/mybb/blob/mybb_1812/inc/class_datacache.php#L812

https://wiki.php.net/rfc/counting_non_countables
@dvz dvz added b:1.8 Branch: 1.8.x t:bug Type: Bug. An issue causing error / flaw / malfunction p:high Priority: High. To resolve with high preference s:confirmed Status: Confirmed. Retested and found the issue exists labels Aug 10, 2017
@dvz dvz added this to the 1.8.13 milestone Aug 10, 2017
@dvz dvz mentioned this issue Aug 10, 2017
Merged
@dvz dvz added s:resolved Status: Resolved. Solution implemented or scheduled and removed s:confirmed Status: Confirmed. Retested and found the issue exists labels Aug 10, 2017
@dvz
Copy link
Contributor Author

dvz commented Aug 10, 2017

https://github.com/mybb/mybb/blob/mybb_1812/admin/inc/functions_themes.php#L1113

@dvz dvz mentioned this issue Dec 2, 2017
Closed
Eldenroot pushed a commit to Eldenroot/mybb that referenced this issue May 8, 2018
@dvz @Eldenroot
Fix mybb#2824 Counting of non-countable objects emits Warning on PHP …
036cf66 
…7.2 (mybb#2826)

* Fix variable type in datacache::build_moderators()

* Add type check in update_theme_stylesheet_list()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
b:1.8 Branch: 1.8.x p:high Priority: High. To resolve with high preference s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Projects
None yet
Milestone
1.8.13
Development

No branches or pull requests
1 participant
@dvz