Plugin hook adding/changing

[euantorano]

As per this thread, there are some places where it would be useful to have some new hooks. Additionally, there are some places where hooks with the same name are ran multiple times. As part of 1.10, it would be good to ensure hook name are used only once and to look at which additional hooks can be added.

Probably the best thing to do is to comment here or in the thread a hook you'd like to see or that you know is duplicated and we'll check them off as we go:

• Hook in the send_pm function after the global line

[dvz]

Hooks that can be run in more than one place:

• member_do_register_end (6)
• member_do_login_end (2)
• usercp_editsig_end (2)
• modcp_do_modqueue_end (3)
• modcp_modlogs_result (2)
• report_do_report_end (2)
• search_results_end (2)
• search_do_search_process (6)
• search_do_search_end (2)
• archive_forum_thread (2)
• admin_user_mass_email_preview_end (2)
• admin_tools_cache_rebuild_commit (5)
• admin_tools_tasks_enable_commit (2)
• private_do_tracking_end (3)
• warnings_warning (2)
• datahandler_post_insert_post (2)
• datahandler_post_insert_thread (2)
• datahandler_post_insert_thread_post (2)
• report_content_types (2)
• printthread_start (2)

Those are presumably evoked with different conditions @labrocca

[dragonexpert]

I think modcp_modlogs_result is okay because it is used for custom mod log entries when you first view the mod cp and for when you are checking the mod logs. I don't see a reason why that would need to change. I haven't used the other hooks before so I don't know as much about them.

[Sama34]

Is this only for 1.10? I would like to suggest a new hook between the following lines:
https://github.com/mybb/mybb/blob/feature/admin/modules/forum/management.php#L868-L869

zingaburga/XThreads-MyBB-Plugin#25

[euantorano]

Nope, we’re fine adding useful hooks in any release in my opinion.

…

On Wed, 10 Jun 2020, at 21:45, Omar Gonzalez wrote: Is this only for `1.10`? I would like to suggest a new hook between the following lines: https://github.com/mybb/mybb/blob/feature/admin/modules/forum/management.php#L868-L869 zingaburga/XThreads-MyBB-Plugin#25 <zingaburga/XThreads-MyBB-Plugin#25> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2919 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFW24LHUYDMNHLZ4P7IO5DRV7WINANCNFSM4EFKKSIA>.