Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins hooks in forum display #3724

Closed
chack1172 opened this issue Jun 16, 2019 · 6 comments · Fixed by #3858
Closed

Plugins hooks in forum display #3724

chack1172 opened this issue Jun 16, 2019 · 6 comments · Fixed by #3858
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:enhancement Type: Enhancement. Contains minor improvements
Milestone
1.8.23

Comments

@chack1172
Copy link
Contributor

I think I new hook should be added in forumdisplay.php after the $threadcache and $tids are defined.
This will help making only one new query to the database if extra data is needed for a plugin.
Otherwise they should run one extra query for each thread displayed.
@Eldenroot
Copy link
Contributor

@chack1172 - could you please open a PR for that?

@veryard
Copy link
Contributor

veryard commented Sep 1, 2019

I'm not 100% sure if this is correct, a bit more detail would help, if someone can check see if this is okay.

Thanks

@Starpaul20
Copy link
Member

Since this issue has come up, there is one hook I want to add to forumdisplay.php, just above the eval for $threadslist. I'm making a PR for that right now.

@euantorano euantorano mentioned this issue Sep 25, 2019
Merged
euantorano pushed a commit that referenced this issue Sep 25, 2019
@Starpaul20 @euantorano
New plugin hook for forumdisplay.php (as mentioned in #3724) (#3805)
80d1b9f
@Eldenroot
Copy link
Contributor

@veryard where is your PR? If you have any issues, let me know and I will help you

@Eldenroot
Copy link
Contributor

@PaulBender and @chack1172 - are you willing to create a PR for the first part of this issue? Thank you

@veryard
Copy link
Contributor

veryard commented Oct 8, 2019

@Eldenroot Looks like I made a commit to my fork rather than a PR.

https://github.com/veryard/mybb/commit/149d4329cdc5631ee319a12a8efb09692aad788e

Eldenroot added a commit to Eldenroot/mybb that referenced this issue Jan 4, 2020
@Eldenroot
Fixes mybb#3724 - Forumdisplay hook
a7a1eb5 
Resolves mybb#3724
@Eldenroot Eldenroot mentioned this issue Jan 4, 2020
Merged
euantorano pushed a commit that referenced this issue Jan 4, 2020
@Eldenroot @euantorano
Fixes #3724 - Forumdisplay hook (#3858)
f46c514 
Resolves #3724
@euantorano euantorano added b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:enhancement Type: Enhancement. Contains minor improvements labels Jan 4, 2020
@euantorano euantorano added this to the 1.8.23 milestone Jan 4, 2020
lairdshaw pushed a commit to lairdshaw/mybb that referenced this issue Oct 11, 2021
@Starpaul20 @lairdshaw
New plugin hook for forumdisplay.php (as mentioned in mybb#3724) (myb…
9f9e72c 
…b#3805)

[Rebased for 1.9 by Laird]
lairdshaw pushed a commit to lairdshaw/mybb that referenced this issue Oct 11, 2021
@Eldenroot @lairdshaw
Fixes mybb#3724 - Forumdisplay hook (mybb#3858)
c959dd6 
[Rebased for 1.9 by Laird]

Resolves mybb#3724
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:enhancement Type: Enhancement. Contains minor improvements
Projects
None yet
Milestone
1.8.23
Development

Successfully merging a pull request may close this issue.

Fixes #3724 - Forumdisplay hook Eldenroot/mybb
5 participants
@euantorano @Eldenroot @Starpaul20 @veryard @chack1172