Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timezone select, UCP's Thread Subscriptions list output overwritten #4270

Closed
dvz opened this issue Feb 24, 2021 · 0 comments · Fixed by #4273
Closed

Timezone select, UCP's Thread Subscriptions list output overwritten #4270

dvz opened this issue Feb 24, 2021 · 0 comments · Fixed by #4273
Assignees
@Ben-MyBB
Labels
b:1.8 Branch: 1.8.x dev-branch Affecting unreleased codebase easy-pick Not difficult; good first issue to resolve s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction t:regression Type: Regression. Degraded functionality after update
Milestone
1.8.27

Comments

@dvz
Copy link
Contributor

dvz commented Feb 24, 2021

Some variable concatenating assignment operators .= were incorrectly changed to assignment operators = in #4095, resulting in overwriting of loop iteration data.

Regression from #4095
@dvz dvz added t:bug Type: Bug. An issue causing error / flaw / malfunction s:confirmed Status: Confirmed. Retested and found the issue exists b:1.8 Branch: 1.8.x easy-pick Not difficult; good first issue to resolve t:regression Type: Regression. Degraded functionality after update dev-branch Affecting unreleased codebase labels Feb 24, 2021
@dvz dvz added this to the 1.8.26 milestone Feb 24, 2021
@Ben-MyBB Ben-MyBB self-assigned this Feb 24, 2021
@Ben-MyBB Ben-MyBB mentioned this issue Feb 24, 2021
Merged
euantorano added a commit that referenced this issue Mar 2, 2021
@Ben-MyBB @euantorano
Resolves #4270 - Correct assignment operators (#4273)
ed09961 
* Change assignment operators

* Initialize `$timezone_option`.

* Initialize `$latest_subscribed_threads`.

Co-authored-by: Euan <euantorano@users.noreply.github.com>
@euantorano euantorano added s:resolved Status: Resolved. Solution implemented or scheduled and removed s:confirmed Status: Confirmed. Retested and found the issue exists labels Mar 2, 2021
lairdshaw pushed a commit to lairdshaw/mybb that referenced this issue Oct 11, 2021
@Ben-MyBB @euantorano @lairdshaw
Resolves mybb#4270 - Correct assignment operators (mybb#4273)
b28a427 
[Rebased for 1.9 by Laird]

* Change assignment operators

* Initialize `$timezone_option`.

* Initialize `$latest_subscribed_threads`.

Co-authored-by: Euan <euantorano@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ben-MyBB Ben-MyBB

Labels
b:1.8 Branch: 1.8.x dev-branch Affecting unreleased codebase easy-pick Not difficult; good first issue to resolve s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction t:regression Type: Regression. Degraded functionality after update
Projects
None yet
Milestone
1.8.27
Development

Successfully merging a pull request may close this issue.

Resolves #4270 - Correct assignment operators Ben-MyBB/mybb
3 participants
@euantorano @dvz @Ben-MyBB