Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCEditor returns unsupported MyCode format for quotes with no username #4492

Closed
dvz opened this issue Nov 8, 2021 · 2 comments · Fixed by #4493
Closed

SCEditor returns unsupported MyCode format for quotes with no username #4492

dvz opened this issue Nov 8, 2021 · 2 comments · Fixed by #4493
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Milestone
1.8.31

Comments

@dvz
Copy link
Member

dvz commented Nov 8, 2021

Quoting a Guest, who didn't supply a username, may result in unparsed MyCode being displayed when using SCEditor.

When a [quote="" ...] MyCode tag with an empty author value and additional attributes is created in the parse_quoted_message() function and added to <textarea> elements, SCEditor may remove the empty attribute code ="" and output a [quote ...] tag, a format not supported by the MyBB parser.

Reported in:
@dvz dvz added t:bug Type: Bug. An issue causing error / flaw / malfunction s:confirmed Status: Confirmed. Retested and found the issue exists b:1.8 Branch: 1.8.x labels Nov 8, 2021
Eldenroot added a commit to Eldenroot/mybb that referenced this issue Nov 8, 2021
@Eldenroot
Fixes mybb#4492 - SCEditor returns unsupported mycode format...
b5e2d6f 
Resolves mybb#4492 

Fix by doylecc
@Eldenroot Eldenroot mentioned this issue Nov 8, 2021
Merged
@mmikeww
Copy link

mmikeww commented Nov 12, 2021

I also reported this bug here:
https://community.mybb.com/thread-234131.html

I just tested the fix in PR #4493 and confirmed it worked in both cases when quoting a guest with no username 1. when using quick reply box to quote, and 2. when using full editor to quote

@Eldenroot
Copy link
Contributor

@mmikeww thx for testing the PR!

@dvz - can you add this to 1.8.30 milestone?

@dvz dvz added this to the 1.8.30 milestone Nov 24, 2021
@dvz dvz closed this as completed in #4493 Jul 23, 2022
dvz pushed a commit that referenced this issue Jul 23, 2022
@Eldenroot
Fixes #4492 - SCEditor returns unsupported mycode format... (#4493)
c81b932 
* Fixes #4492 - SCEditor returns unsupported mycode format...

Resolves #4492 

Fix by doylecc

* Update functions_posting.php

* Update functions_posting.php
@dvz dvz added s:resolved Status: Resolved. Solution implemented or scheduled and removed s:confirmed Status: Confirmed. Retested and found the issue exists labels Aug 29, 2022
dvz pushed a commit that referenced this issue Dec 5, 2022
@Eldenroot @dvz
Fixes #4492 - SCEditor returns unsupported mycode format... (#4493)
7bb9439 
* Fixes #4492 - SCEditor returns unsupported mycode format...

Resolves #4492

Fix by doylecc

* Update functions_posting.php

* Update functions_posting.php

(cherry picked from commit c81b932)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Projects
None yet
Milestone
1.8.31
Development

Successfully merging a pull request may close this issue.

Fixes #4492 - SCEditor returns unsupported mycode format... Eldenroot/mybb
3 participants
@Eldenroot @mmikeww @dvz