Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide stuff users don't have permission to use #454

Closed
13 tasks done
Starpaul20 opened this issue Apr 29, 2014 · 15 comments
Closed
13 tasks done

Hide stuff users don't have permission to use #454

Starpaul20 opened this issue Apr 29, 2014 · 15 comments
Assignees
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:enhancement Type: Enhancement. Contains minor improvements
Milestone

Comments

@Starpaul20
Copy link
Member

Starpaul20 commented Apr 29, 2014

Hide any stuff users don't have permission to use.

  • The avatar upload box
  • PM compose links in User CP & PM folders
  • Send this Thread to a Friend link on threads and portal
  • New Thread button
  • New Reply button
  • Header Search box
  • Header links (Calendar, Member List, Search)

Additionally, we should hide things that have nothing to show.

  • Stop Tracking button on PM tracking page if no PMs are being tracked
  • Remove Avatar button if user has no avatar
  • Hide theme selector in footer and User CP if only one theme exists
  • Hide language selector in User CP and registration form if only one language exists
  • Hide Jump to calendar if only one calendar exists
  • Hide calendar drop down when adding an event if only one calendar exists
@Starpaul20 Starpaul20 added this to the 1.8 Beta 2 milestone Apr 29, 2014
@Starpaul20 Starpaul20 self-assigned this Apr 29, 2014
Starpaul20 added a commit that referenced this issue Jun 13, 2014
Avatar upload box & PM compose links
@Starpaul20
Copy link
Member Author

Starpaul20 commented Jun 13, 2014

I'm going to split this across several commits. The first commit fixes the avatar upload box and PM compose links.

Starpaul20 added a commit that referenced this issue Jun 13, 2014
Send this Thread link on threads and portal
@Starpaul20
Copy link
Member Author

Starpaul20 commented Jun 13, 2014

This fixes the Send this Thread to a Friend link on threads and portal

Nik101010 pushed a commit to Nik101010/mybb that referenced this issue Jun 13, 2014
Nik101010 pushed a commit to Nik101010/mybb that referenced this issue Jun 13, 2014
Send this Thread link on threads and portal
@Starpaul20
Copy link
Member Author

Starpaul20 commented Jun 13, 2014

This fixes the New Thread and New Reply buttons

Starpaul20 added a commit that referenced this issue Jun 13, 2014
@Starpaul20
Copy link
Member Author

Starpaul20 commented Jun 13, 2014

This is finished

@DiogoParrinha
Copy link
Contributor

DiogoParrinha commented Jun 19, 2014

@PaulBender

@Starpaul20
Copy link
Member Author

Starpaul20 commented Jun 19, 2014

I can add those

@DiogoParrinha
Copy link
Contributor

DiogoParrinha commented Jun 24, 2014

I've removed the Fixed label meanwhile.

Starpaul20 added a commit that referenced this issue Jun 24, 2014
Hide jump to calendar if only one calendar exists & hide calendar drop down when adding an event if only one calendar exists
Starpaul20 added a commit that referenced this issue Jun 25, 2014
Hides theme selector in footer and User CP if only one theme exists; moved theme selector's hardcoded HTML to template (#756)
Starpaul20 added a commit that referenced this issue Jun 25, 2014
Hide language selector in User CP if only one language exists and moved language option to template (#756)
Starpaul20 added a commit that referenced this issue Jun 25, 2014
Remove the 'Remove Avatar' button if user has no avatar
Starpaul20 added a commit that referenced this issue Jun 26, 2014
Removes 'Stop Tracking' buttons on PM tracking page if no PMs are being tracked
@Starpaul20
Copy link
Member Author

Starpaul20 commented Jun 26, 2014

Alright, this is now all done.

@Destroy666x
Copy link
Contributor

Destroy666x commented Jun 26, 2014

What about language selector on registration page and ACP theme selector (also count <= 1)?]

Starpaul20 added a commit that referenced this issue Jun 26, 2014
Hide language selector on registration if only one language exists
Starpaul20 added a commit that referenced this issue Jun 26, 2014
Display theme selector when editing user in Admin CP
@Starpaul20
Copy link
Member Author

Starpaul20 commented Jun 26, 2014

Fixed the language selector on registration.

Stuff in the Admin CP should be shown regardless.

@Destroy666x
Copy link
Contributor

Destroy666x commented Jun 26, 2014

And few more front-end things I found that were not on the list:

  • hide "Revert to group default" checkbox in UCP -> Edit Profile if there is no custom usertitle
  • hide "Move to Banned Group" selector in modcp.php?action=banuser if there is <= 1 banned group
  • hide "Add to Ignore List" button in profiles of users which we have on buddy list
  • hide "Add to Buddy List" button in profiles of users which we have on ignore list
  • hide "Rate User" button on our own reputation page
  • hide "Empty Folders" and "Download Messages" in private.php if $mybb->user['totalpms'] is not higher than 0
  • hide contact link for guests in footer if $mybb->settings['contact_guests'] is false/0

And something similar, except it's not hiding (but saves redundant click time like all things here), don't know if I need to create another issue for this:

  • select the "Custom Reason" radio automatically in warnings.php?action=warn if there are no default types of warnings created in ACP

I went through all front-end scripts and I guess that's all. At least I can't find anything else.

Starpaul20 added a commit that referenced this issue Jun 26, 2014
Hide "Revert to group default" checkbox when editing your title & Hide "Rate User" button on own reputation page
Starpaul20 added a commit that referenced this issue Jun 26, 2014
Hide "Move to Banned Group" selector in Mod CP if only one banned group exists
Starpaul20 added a commit that referenced this issue Jun 26, 2014
Hide "Add to Buddy/Ignore List" buttons in profiles where user exists on the other list
Starpaul20 added a commit that referenced this issue Jun 27, 2014
Hide "Contact Us" link if diabled to guests or disabled altogether.
@DiogoParrinha
Copy link
Contributor

DiogoParrinha commented Jun 29, 2014

@PaulBender there are still some tasks left to finish.

Starpaul20 added a commit that referenced this issue Jun 29, 2014
Hide "Empty Folders" and "Download Messages" in private.php if user has no PMs
Starpaul20 added a commit that referenced this issue Jun 29, 2014
Select the "Custom Reason" radio automatically if there are no default types of warnings
@Starpaul20
Copy link
Member Author

Starpaul20 commented Jun 29, 2014

Okay, everything is now done

@DiogoParrinha
Copy link
Contributor

DiogoParrinha commented Jun 30, 2014

Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:enhancement Type: Enhancement. Contains minor improvements
Projects
None yet
Development

No branches or pull requests

4 participants