New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide stuff users don't have permission to use #454

Closed
PaulBender opened this Issue Apr 29, 2014 · 15 comments

Comments

Projects
None yet
4 participants
@PaulBender
Member

PaulBender commented Apr 29, 2014

Hide any stuff users don't have permission to use.

  • The avatar upload box
  • PM compose links in User CP & PM folders
  • Send this Thread to a Friend link on threads and portal
  • New Thread button
  • New Reply button
  • Header Search box
  • Header links (Calendar, Member List, Search)

Additionally, we should hide things that have nothing to show.

  • Stop Tracking button on PM tracking page if no PMs are being tracked
  • Remove Avatar button if user has no avatar
  • Hide theme selector in footer and User CP if only one theme exists
  • Hide language selector in User CP and registration form if only one language exists
  • Hide Jump to calendar if only one calendar exists
  • Hide calendar drop down when adding an event if only one calendar exists

@PaulBender PaulBender added this to the 1.8 Beta 2 milestone Apr 29, 2014

@PaulBender PaulBender self-assigned this Apr 29, 2014

PaulBender added a commit that referenced this issue Jun 13, 2014

Working on #454 Hide stuff users don't have permission to use
Avatar upload box & PM compose links
@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 13, 2014

Member

I'm going to split this across several commits. The first commit fixes the avatar upload box and PM compose links.

Member

PaulBender commented Jun 13, 2014

I'm going to split this across several commits. The first commit fixes the avatar upload box and PM compose links.

PaulBender added a commit that referenced this issue Jun 13, 2014

Working on #454 Hide stuff users don't have permission to use
Send this Thread link on threads and portal
@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 13, 2014

Member

This fixes the Send this Thread to a Friend link on threads and portal

Member

PaulBender commented Jun 13, 2014

This fixes the Send this Thread to a Friend link on threads and portal

Nik101010 added a commit to Nik101010/mybb that referenced this issue Jun 13, 2014

Nik101010 added a commit to Nik101010/mybb that referenced this issue Jun 13, 2014

Working on #454 Hide stuff users don't have permission to use
Send this Thread link on threads and portal
@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 13, 2014

Member

This fixes the New Thread and New Reply buttons

Member

PaulBender commented Jun 13, 2014

This fixes the New Thread and New Reply buttons

PaulBender added a commit that referenced this issue Jun 13, 2014

@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 13, 2014

Member

This is finished

Member

PaulBender commented Jun 13, 2014

This is finished

@PaulBender PaulBender added the fixed label Jun 13, 2014

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo
Contributor

PirataNervo commented Jun 19, 2014

@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 19, 2014

Member

I can add those

Member

PaulBender commented Jun 19, 2014

I can add those

@PirataNervo PirataNervo removed the fixed label Jun 24, 2014

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 24, 2014

Contributor

I've removed the Fixed label meanwhile.

Contributor

PirataNervo commented Jun 24, 2014

I've removed the Fixed label meanwhile.

PaulBender added a commit that referenced this issue Jun 24, 2014

Working on #454 Hide stuff users don't have permission to use
Hide jump to calendar if only one calendar exists & hide calendar drop down when adding an event if only one calendar exists

PaulBender added a commit that referenced this issue Jun 25, 2014

Fixes #454 Hide stuff users don't have permission to use
Hides theme selector in footer and User CP if only one theme exists; moved theme selector's hardcoded HTML to template (#756)

PaulBender added a commit that referenced this issue Jun 25, 2014

Working on #454 Hide stuff users don't have permission to use
Hide language selector in User CP if only one language exists and moved language option to template (#756)

PaulBender added a commit that referenced this issue Jun 25, 2014

Working on #454 Hide stuff users don't have permission to use
Remove the 'Remove Avatar' button if user has no avatar

PaulBender added a commit that referenced this issue Jun 26, 2014

Working on #454 Hide stuff users don't have permission to use
Removes 'Stop Tracking' buttons on PM tracking page if no PMs are being tracked
@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 26, 2014

Member

Alright, this is now all done.

Member

PaulBender commented Jun 26, 2014

Alright, this is now all done.

@PaulBender PaulBender added the fixed label Jun 26, 2014

@Destroy666x

This comment has been minimized.

Show comment
Hide comment
@Destroy666x

Destroy666x Jun 26, 2014

Contributor

What about language selector on registration page and ACP theme selector (also count <= 1)?]

Contributor

Destroy666x commented Jun 26, 2014

What about language selector on registration page and ACP theme selector (also count <= 1)?]

PaulBender added a commit that referenced this issue Jun 26, 2014

Working on #454 Hide stuff users don't have permission to use
Hide language selector on registration if only one language exists

PaulBender added a commit that referenced this issue Jun 26, 2014

Working on #454 Hide stuff users don't have permission to use
Display theme selector when editing user in Admin CP
@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 26, 2014

Member

Fixed the language selector on registration.

Stuff in the Admin CP should be shown regardless.

Member

PaulBender commented Jun 26, 2014

Fixed the language selector on registration.

Stuff in the Admin CP should be shown regardless.

@Destroy666x

This comment has been minimized.

Show comment
Hide comment
@Destroy666x

Destroy666x Jun 26, 2014

Contributor

And few more front-end things I found that were not on the list:

  • hide "Revert to group default" checkbox in UCP -> Edit Profile if there is no custom usertitle
  • hide "Move to Banned Group" selector in modcp.php?action=banuser if there is <= 1 banned group
  • hide "Add to Ignore List" button in profiles of users which we have on buddy list
  • hide "Add to Buddy List" button in profiles of users which we have on ignore list
  • hide "Rate User" button on our own reputation page
  • hide "Empty Folders" and "Download Messages" in private.php if $mybb->user['totalpms'] is not higher than 0
  • hide contact link for guests in footer if $mybb->settings['contact_guests'] is false/0

And something similar, except it's not hiding (but saves redundant click time like all things here), don't know if I need to create another issue for this:

  • select the "Custom Reason" radio automatically in warnings.php?action=warn if there are no default types of warnings created in ACP

I went through all front-end scripts and I guess that's all. At least I can't find anything else.

Contributor

Destroy666x commented Jun 26, 2014

And few more front-end things I found that were not on the list:

  • hide "Revert to group default" checkbox in UCP -> Edit Profile if there is no custom usertitle
  • hide "Move to Banned Group" selector in modcp.php?action=banuser if there is <= 1 banned group
  • hide "Add to Ignore List" button in profiles of users which we have on buddy list
  • hide "Add to Buddy List" button in profiles of users which we have on ignore list
  • hide "Rate User" button on our own reputation page
  • hide "Empty Folders" and "Download Messages" in private.php if $mybb->user['totalpms'] is not higher than 0
  • hide contact link for guests in footer if $mybb->settings['contact_guests'] is false/0

And something similar, except it's not hiding (but saves redundant click time like all things here), don't know if I need to create another issue for this:

  • select the "Custom Reason" radio automatically in warnings.php?action=warn if there are no default types of warnings created in ACP

I went through all front-end scripts and I guess that's all. At least I can't find anything else.

PaulBender added a commit that referenced this issue Jun 26, 2014

Working on #454 Hide stuff users don't have permission to use
Hide "Revert to group default" checkbox when editing your title & Hide "Rate User" button on own reputation page

PaulBender added a commit that referenced this issue Jun 26, 2014

Working on #454 Hide stuff users don't have permission to use
Hide "Move to Banned Group" selector in Mod CP if only one banned group exists

PaulBender added a commit that referenced this issue Jun 26, 2014

Working on #454 Hide stuff users don't have permission to use
Hide "Add to Buddy/Ignore List" buttons in profiles where user exists on the other list

PaulBender added a commit that referenced this issue Jun 27, 2014

Working on #454 Hide stuff users don't have permission to use
Hide "Contact Us" link if diabled to guests or disabled altogether.
@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 29, 2014

Contributor

@PaulBender there are still some tasks left to finish.

Contributor

PirataNervo commented Jun 29, 2014

@PaulBender there are still some tasks left to finish.

@PirataNervo PirataNervo removed the fixed label Jun 29, 2014

PaulBender added a commit that referenced this issue Jun 29, 2014

Working on #454 Hide stuff users don't have permission to use
Hide "Empty Folders" and "Download Messages" in private.php if user has no PMs

PaulBender added a commit that referenced this issue Jun 29, 2014

Working on #454 Hide stuff users don't have permission to use
Select the "Custom Reason" radio automatically if there are no default types of warnings
@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 29, 2014

Member

Okay, everything is now done

Member

PaulBender commented Jun 29, 2014

Okay, everything is now done

@PaulBender PaulBender added the fixed label Jun 29, 2014

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 30, 2014

Contributor

Closing this.

Contributor

PirataNervo commented Jun 30, 2014

Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment