Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMTP only using TLS 1.0 in specific PHP versions #4769

Closed
Stefan-MyBB opened this issue Oct 19, 2023 · 0 comments · Fixed by #4770
Closed

SMTP only using TLS 1.0 in specific PHP versions #4769

Stefan-MyBB opened this issue Oct 19, 2023 · 0 comments · Fixed by #4770
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Milestone
1.8.37

Comments

@Stefan-MyBB
Copy link
Contributor

MyBB uses PHP constant STREAM_CRYPTO_METHOD_TLS_CLIENT to initiate the TLS connection:

mybb/inc/mailhandlers/smtp.php

Line 317 in a6bff07

if(!@stream_socket_enable_crypto($this->connection, true, STREAM_CRYPTO_METHOD_TLS_CLIENT))

Unfortunately this constant had some breaking changes in the past. Initially it meant "any TLS version" but in PHP 5.6.7 is was changed to "only TLS 1.0". This was changed back in PHP 7.2.

Although these PHP versions are fairly old there are officially supported by MyBB.
Stefan-MyBB added a commit to Stefan-MyBB/mybb that referenced this issue Oct 19, 2023
@Stefan-MyBB
Fixes mybb#4769 SMTP only using TLS 1.0 in specific PHP versions
0a872fa
@Stefan-MyBB Stefan-MyBB mentioned this issue Oct 19, 2023
Merged
@dvz dvz closed this as completed in #4770 Oct 25, 2023
dvz pushed a commit that referenced this issue Oct 25, 2023
@Stefan-MyBB @dvz
Fixes #4769 SMTP only using TLS 1.0 in specific PHP versions
425e6ee
@dvz dvz added t:bug Type: Bug. An issue causing error / flaw / malfunction b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled labels Oct 25, 2023
@dvz dvz added this to the 1.8.37 milestone Oct 25, 2023
dvz pushed a commit that referenced this issue Nov 6, 2023
@Stefan-MyBB @dvz
Fixes #4769 SMTP only using TLS 1.0 in specific PHP versions
6bfebc5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Projects
None yet
Milestone
1.8.37
Development

Successfully merging a pull request may close this issue.

Fixes #4769 SMTP only using TLS 1.0 in specific PHP versions Stefan-MyBB/mybb
2 participants
@Stefan-MyBB @dvz