Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative Time #558

Closed
DiogoParrinha opened this issue May 27, 2014 · 10 comments
Closed

Relative Time #558

DiogoParrinha opened this issue May 27, 2014 · 10 comments
Labels
b:1.8 Branch: 1.8.x t:feature Type: Feature. Implements new functionality
Milestone

Comments

@DiogoParrinha
Copy link
Contributor

Original issue on 1.8 private repo: https://github.com/mybb/MyBB18/issues/15
What needs to be done: check if it's been finished or not.

To quote:

Research methods to implement real relative time; there is already a function for calculating it within MyBB and would simplify time variables within the templates.

@DiogoParrinha DiogoParrinha added this to the 1.8 Beta 1 milestone May 27, 2014
@Starpaul20
Copy link
Member

Could we expand the relative time thing for everything in the last 12 hours? Currently it only applies for the last 60 minutes.

@DiogoParrinha
Copy link
Contributor Author

So you can confirm that it's working where it should, at least for the last 60 minutes? I believe we can expand it, though I'm not sure what implications it has.

@Starpaul20
Copy link
Member

Yes, it works for the last 60 minutes.

@DiogoParrinha
Copy link
Contributor Author

That's good, I'm alright with extending to the last 12h. @stefan-st @Sama34 @WildcardSearch @Polarbear541 @PenguinPaul any objections?

@PenguinPaul
Copy link
Contributor

Fine by me

@DiogoParrinha
Copy link
Contributor Author

@PaulBender let me know if you can do this or if you want I can do it myself - I just have to look at how relative time is done here (if by JS or in PHP).

@Starpaul20
Copy link
Member

Yeah, I can do this one easily.

Starpaul20 added a commit that referenced this issue May 28, 2014
Expanded relative time to the last 12 hours
@Starpaul20
Copy link
Member

Done

@DiogoParrinha
Copy link
Contributor Author

I guess we can close this then.

@Sama34
Copy link
Contributor

Sama34 commented May 29, 2014

We could as well add a setting. Probably using relative time for "6 days ago" could be nice as well.

ATofighi pushed a commit to MyBBIr/mybb that referenced this issue May 29, 2014
Expanded relative time to the last 12 hours
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b:1.8 Branch: 1.8.x t:feature Type: Feature. Implements new functionality
Projects
None yet
Development

No branches or pull requests

4 participants