New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative Time #558

Closed
PirataNervo opened this Issue May 27, 2014 · 10 comments

Comments

Projects
None yet
4 participants
@PirataNervo
Contributor

PirataNervo commented May 27, 2014

Original issue on 1.8 private repo: https://github.com/mybb/MyBB18/issues/15
What needs to be done: check if it's been finished or not.

To quote:

Research methods to implement real relative time; there is already a function for calculating it within MyBB and would simplify time variables within the templates.

@PirataNervo PirataNervo added this to the 1.8 Beta 1 milestone May 27, 2014

@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender May 28, 2014

Member

Could we expand the relative time thing for everything in the last 12 hours? Currently it only applies for the last 60 minutes.

Member

PaulBender commented May 28, 2014

Could we expand the relative time thing for everything in the last 12 hours? Currently it only applies for the last 60 minutes.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo May 28, 2014

Contributor

So you can confirm that it's working where it should, at least for the last 60 minutes? I believe we can expand it, though I'm not sure what implications it has.

Contributor

PirataNervo commented May 28, 2014

So you can confirm that it's working where it should, at least for the last 60 minutes? I believe we can expand it, though I'm not sure what implications it has.

@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender May 28, 2014

Member

Yes, it works for the last 60 minutes.

Member

PaulBender commented May 28, 2014

Yes, it works for the last 60 minutes.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo May 28, 2014

Contributor

That's good, I'm alright with extending to the last 12h. @Stefan-ST @Sama34 @WildcardSearch @Polarbear541 @PenguinPaul any objections?

Contributor

PirataNervo commented May 28, 2014

That's good, I'm alright with extending to the last 12h. @Stefan-ST @Sama34 @WildcardSearch @Polarbear541 @PenguinPaul any objections?

@PenguinPaul

This comment has been minimized.

Show comment
Hide comment
@PenguinPaul

PenguinPaul May 28, 2014

Contributor

Fine by me

Contributor

PenguinPaul commented May 28, 2014

Fine by me

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo May 28, 2014

Contributor

@PaulBender let me know if you can do this or if you want I can do it myself - I just have to look at how relative time is done here (if by JS or in PHP).

Contributor

PirataNervo commented May 28, 2014

@PaulBender let me know if you can do this or if you want I can do it myself - I just have to look at how relative time is done here (if by JS or in PHP).

@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender May 28, 2014

Member

Yeah, I can do this one easily.

Member

PaulBender commented May 28, 2014

Yeah, I can do this one easily.

PaulBender added a commit that referenced this issue May 28, 2014

Working on #558 Relative Time
Expanded relative time to the last 12 hours
@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender May 28, 2014

Member

Done

Member

PaulBender commented May 28, 2014

Done

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo May 28, 2014

Contributor

I guess we can close this then.

Contributor

PirataNervo commented May 28, 2014

I guess we can close this then.

@Sama34

This comment has been minimized.

Show comment
Hide comment
@Sama34

Sama34 May 29, 2014

Contributor

We could as well add a setting. Probably using relative time for "6 days ago" could be nice as well.

Contributor

Sama34 commented May 29, 2014

We could as well add a setting. Probably using relative time for "6 days ago" could be nice as well.

ATofighi added a commit to MyBBIr/mybb that referenced this issue May 29, 2014

Working on #558 Relative Time
Expanded relative time to the last 12 hours
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment