Admin and Email activation option #685

Closed
PaulBender opened this Issue Jun 2, 2014 · 7 comments

Comments

Projects
None yet
2 participants
@PaulBender
Member

PaulBender commented Jun 2, 2014

Add an option to require both Email and Admin activation when registering.

@PaulBender PaulBender added this to the 1.8 Beta 2 milestone Jun 2, 2014

@PaulBender PaulBender self-assigned this Jun 2, 2014

@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 9, 2014

Member

This is finished

Member

PaulBender commented Jun 9, 2014

This is finished

@PaulBender PaulBender added the fixed label Jun 9, 2014

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 23, 2014

Contributor

@PaulBender this didn't seem to work properly for me I think. I've manually updated the 'validated' field on my localhost to 1 when the "Both" option was set for the Activation setting. It automatically made my user join the Registered group instead of the Awaiting Activation. The same procedure for "Email only" worked fine.

Contributor

PirataNervo commented Jun 23, 2014

@PaulBender this didn't seem to work properly for me I think. I've manually updated the 'validated' field on my localhost to 1 when the "Both" option was set for the Activation setting. It automatically made my user join the Registered group instead of the Awaiting Activation. The same procedure for "Email only" worked fine.

@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 24, 2014

Member

Looks like I missed one piece of code. Committing the fix now...

Member

PaulBender commented Jun 24, 2014

Looks like I missed one piece of code. Committing the fix now...

PaulBender added a commit that referenced this issue Jun 24, 2014

@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 24, 2014

Member

It should be fixed now.

Member

PaulBender commented Jun 24, 2014

It should be fixed now.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 24, 2014

Contributor

It works. I'm just not sure about why this is useful. What's the difference between Both and Admin only? After all, it requires admin approval. And the admin can approve regardless of the email has been approved or not.

Contributor

PirataNervo commented Jun 24, 2014

It works. I'm just not sure about why this is useful. What's the difference between Both and Admin only? After all, it requires admin approval. And the admin can approve regardless of the email has been approved or not.

@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 24, 2014

Member

With just admin approval you have no way of telling if someone's email is valid or not.

Member

PaulBender commented Jun 24, 2014

With just admin approval you have no way of telling if someone's email is valid or not.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 24, 2014

Contributor

Good point. Closing this.

Contributor

PirataNervo commented Jun 24, 2014

Good point. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment