Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin and Email activation option #685

Closed
Starpaul20 opened this issue Jun 2, 2014 · 7 comments
Closed

Admin and Email activation option #685

Starpaul20 opened this issue Jun 2, 2014 · 7 comments
Assignees
@Starpaul20
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:enhancement Type: Enhancement. Contains minor improvements
Milestone
1.8 Beta 2

Comments

@Starpaul20
Copy link
Member

Add an option to require both Email and Admin activation when registering.
@Starpaul20 Starpaul20 added this to the 1.8 Beta 2 milestone Jun 2, 2014
@Starpaul20 Starpaul20 self-assigned this Jun 2, 2014
Starpaul20 added a commit that referenced this issue Jun 9, 2014
@Starpaul20
Feature #685 Admin and Email activation option
a45cb3c
@Starpaul20
Copy link
Member Author

This is finished

@DiogoParrinha
Copy link
Contributor

@PaulBender this didn't seem to work properly for me I think. I've manually updated the 'validated' field on my localhost to 1 when the "Both" option was set for the Activation setting. It automatically made my user join the Registered group instead of the Awaiting Activation. The same procedure for "Email only" worked fine.

@Starpaul20
Copy link
Member Author

Looks like I missed one piece of code. Committing the fix now...

Starpaul20 added a commit that referenced this issue Jun 24, 2014
@Starpaul20
Feature #685 Admin and Email activation option
f074845 
Fixed bug
@Starpaul20
Copy link
Member Author

It should be fixed now.

@DiogoParrinha
Copy link
Contributor

It works. I'm just not sure about why this is useful. What's the difference between Both and Admin only? After all, it requires admin approval. And the admin can approve regardless of the email has been approved or not.

@Starpaul20
Copy link
Member Author

With just admin approval you have no way of telling if someone's email is valid or not.

@DiogoParrinha
Copy link
Contributor

Good point. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Starpaul20 Starpaul20

Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:enhancement Type: Enhancement. Contains minor improvements
Projects
None yet
Milestone
1.8 Beta 2
Development

No branches or pull requests
2 participants
@DiogoParrinha @Starpaul20