Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin and Email activation option #685

Closed
PaulBender opened this issue Jun 2, 2014 · 7 comments
Closed

Admin and Email activation option #685

PaulBender opened this issue Jun 2, 2014 · 7 comments
Assignees
Milestone

Comments

@PaulBender
Copy link
Member

@PaulBender PaulBender commented Jun 2, 2014

Add an option to require both Email and Admin activation when registering.

@PaulBender PaulBender added this to the 1.8 Beta 2 milestone Jun 2, 2014
@PaulBender PaulBender self-assigned this Jun 2, 2014
@PaulBender
Copy link
Member Author

@PaulBender PaulBender commented Jun 9, 2014

This is finished

@PaulBender PaulBender added the fixed label Jun 9, 2014
@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jun 23, 2014

@PaulBender this didn't seem to work properly for me I think. I've manually updated the 'validated' field on my localhost to 1 when the "Both" option was set for the Activation setting. It automatically made my user join the Registered group instead of the Awaiting Activation. The same procedure for "Email only" worked fine.

@PaulBender
Copy link
Member Author

@PaulBender PaulBender commented Jun 24, 2014

Looks like I missed one piece of code. Committing the fix now...

PaulBender added a commit that referenced this issue Jun 24, 2014
@PaulBender
Copy link
Member Author

@PaulBender PaulBender commented Jun 24, 2014

It should be fixed now.

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jun 24, 2014

It works. I'm just not sure about why this is useful. What's the difference between Both and Admin only? After all, it requires admin approval. And the admin can approve regardless of the email has been approved or not.

@PaulBender
Copy link
Member Author

@PaulBender PaulBender commented Jun 24, 2014

With just admin approval you have no way of telling if someone's email is valid or not.

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jun 24, 2014

Good point. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.