Expand Forum Moderator permissions

[Starpaul20]

Add more permissions to the forum moderator system to allow for more flexibility.

Also add group based permissions to the Mod CP

[Starpaul20]

This adds the permissions to the database and the Admin CP form.

[Starpaul20]

That finishes everything

[Starpaul20]

Okay, that finishes everything.

[xykul]

Can view unapproved threads and posts? and Can view deleted threads and posts? options do not work.

[Starpaul20]

That should fix it.

[xykul]

Thank you.
There is a problem.
Can view unapproved threads and posts?
Can view deleted threads and posts?
Two setting run at the same time, working separately.

[DiogoParrinha]

@PaulBender

[Starpaul20]

@xykul not sure what you mean. The settings work fine for me.

[xykul]

Individual works..
Both work..

[Starpaul20]

Okay, I see what the problem is, fixing...

[Sama34]

Did you only added per-moderator permissions or per-group and/or per-forum too?

[Starpaul20]

It's just per moderator permissions I added

[Sama34]

Do you plan on adding per-group ones like "Can manage annoucements"? I thought you already did.

[Starpaul20]

I added some Mod CP permissions in the moderator permissions (the ones that can be regulated per forum, like announcements, mod queue, reported posts and viewing the mod log). I will add per-group ones right now.

[Starpaul20]

That adds a group-based permission scheme to the Mod CP

[Starpaul20]

This commit adds the new Mod CP permissions for the profile Mod CP links (forgot about them)

It also adds model pop-up to view all user notes if notes are longer than the 100 characters cutoff.

[xykul]

Not displayed.. does not work.

[Destroy666x]

@xykul, does your account have group with Super Moderator permission? If not, you have to report/log/unapprove something in assigned forum(s) to see the menu. Not sure why, I don't think it should be like this.

EDIT: it's actually more complicated and messy than I thought - right now single forum user moderators lose their functionality because they have to be in a group which has these permissions.

[xykul]

Moderators group
modcp.php
210, && $mybb->usergroup['canmanageannounce'] == 1)
215, && $mybb->usergroup['canmanagemodqueue'] == 1)
220, && $mybb->usergroup['canmanagereportedcontent'] == 1)
225, && $mybb->usergroup['canviewmodlogs'] == 1)
lines can not be valid.

[DiogoParrinha]

@PaulBender this is urgent as you have committed directly.

[Starpaul20]

Not quite sure what the problem is. If a user isn't a super moderator they must be assigned to at least one forum in order to see the options in the Forums & Posts menu. Otherwise I'd be showing them links that go nowhere.

I should add a notice in the Admin CP making it clear to Admins that it works that way.

[Destroy666x]

1. Assign moderator X to a forum, leave him in Registered group which doesn't have these permissions ticked.
2. Single moderator can't see anything from his forum even though forum-specific "Moderator CP Permissions" allow him to do it. You have to move him to other group first.

Doesn't make any sense for me.

[Starpaul20]

The Registered group shouldn't have access to the Mod CP at all. If a mod is being left in the Registered group, or any group that doesn't have permission to access the Mod CP, they shouldn't access anything in the Mod CP, period.

[Destroy666x]

Well then, fair enough. I thought the moderator system was confusing already, now it's even more. But whatever, 'period'.

[Sama34]

@PaulBender Assigning an user as moderator to X forum doesn't behave the same that assigning a group to it. Probably it should be modified to work the same way. Currently single moderators are allowed to enter the ModCP regardless of their group permissions.

@Destroy666x, I think per-group permission should override per-moderator ones as it currently does (they may be moderate posts/content but cannot access the ModCP, which the permissions aim to control). But yeah, MyBB is confusing at some parts.

[DiogoParrinha]

I agree with @Sama34

[Starpaul20]

@Sama34 You sure? When I assigned a user to moderate a forum and made sure that they were in a group that can't access the Mod CP, I got a You do not have permission to access this page. error everywhere in the Mod CP.

modcp.php checks to see if you have the Can access Mod CP group permission first and throws an error if you don't have it (or you're a guest).

I agree that per-group permission should override per-moderator permission (the per-moderator permission was really intended to control ability to use that function for the forum the moderator is assigned to).

[Starpaul20]

I updated the descriptions for the moderator permissions dealing with the Mod CP permissions to make it clear that they only apply for that forum.

[Sama34]

Never mind, the reason is the user being moved to the "Moderators" groups when assigned as a single forum moderator. No sure why it works like this.

[DiogoParrinha]

Closing this.