Expand Forum Moderator permissions #688

Closed
PaulBender opened this Issue Jun 2, 2014 · 30 comments

Comments

Projects
None yet
5 participants
@PaulBender
Member

PaulBender commented Jun 2, 2014

Add more permissions to the forum moderator system to allow for more flexibility.

Also add group based permissions to the Mod CP

@PaulBender PaulBender added this to the 1.8 Beta 2 milestone Jun 2, 2014

@PaulBender PaulBender self-assigned this Jun 2, 2014

PaulBender added a commit that referenced this issue Jun 14, 2014

Working on #688 Expand Forum Moderator permissions
Adding the permissions themselves
@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 14, 2014

Member

This adds the permissions to the database and the Admin CP form.

Member

PaulBender commented Jun 14, 2014

This adds the permissions to the database and the Admin CP form.

PaulBender added a commit that referenced this issue Jun 14, 2014

Working on #688 Expand Forum Moderator permissions
Round 1 of updated Mod permissions

PaulBender added a commit that referenced this issue Jun 14, 2014

Working on #688 Expand Forum Moderator permissions
Round 2 of updated Mod permissions. Only showthread.php and Mod CP should be left

PaulBender added a commit that referenced this issue Jun 15, 2014

Working on #688 Expand Forum Moderator permissions
Finished Show Thread and Mod CP
@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 15, 2014

Member

That finishes everything

Member

PaulBender commented Jun 15, 2014

That finishes everything

@PaulBender PaulBender added the feedback label Jun 15, 2014

PaulBender added a commit that referenced this issue Jun 15, 2014

Working on #688 Expand Forum Moderator permissions
Forgot the Forum Display mod menu; improved on Show Thread menu

PaulBender added a commit that referenced this issue Jun 15, 2014

PaulBender added a commit that referenced this issue Jun 15, 2014

Working on #688 Expand Forum Moderator permissions
Permission scheme in Mod CP updated to work with new mod perms

PaulBender added a commit that referenced this issue Jun 16, 2014

Working on #688 Expand Forum Moderator permissions
Finished permission scheme in Mod CP updated to work with new mod perms
@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 16, 2014

Member

Okay, that finishes everything.

Member

PaulBender commented Jun 16, 2014

Okay, that finishes everything.

@PaulBender PaulBender added fixed and removed feedback labels Jun 16, 2014

@xykul

This comment has been minimized.

Show comment
Hide comment
@xykul

xykul Jun 16, 2014

Can view unapproved threads and posts? and Can view deleted threads and posts? options do not work.

xykul commented Jun 16, 2014

Can view unapproved threads and posts? and Can view deleted threads and posts? options do not work.

PaulBender added a commit that referenced this issue Jun 16, 2014

Working on #688 Expand Forum Moderator permissions
Fixed unapproved and deleted permissions
@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 16, 2014

Member

That should fix it.

Member

PaulBender commented Jun 16, 2014

That should fix it.

@xykul

This comment has been minimized.

Show comment
Hide comment
@xykul

xykul Jun 16, 2014

Thank you.
There is a problem.
Can view unapproved threads and posts?
Can view deleted threads and posts?
Two setting run at the same time, working separately.

xykul commented Jun 16, 2014

Thank you.
There is a problem.
Can view unapproved threads and posts?
Can view deleted threads and posts?
Two setting run at the same time, working separately.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
Contributor

PirataNervo commented Jun 19, 2014

@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 19, 2014

Member

@xykul not sure what you mean. The settings work fine for me.

Member

PaulBender commented Jun 19, 2014

@xykul not sure what you mean. The settings work fine for me.

@xykul

This comment has been minimized.

Show comment
Hide comment
@xykul

xykul Jun 20, 2014

Individual works..
Both work..
hatalar

hatalar2

xykul commented Jun 20, 2014

Individual works..
Both work..
hatalar

hatalar2

@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 20, 2014

Member

Okay, I see what the problem is, fixing...

Member

PaulBender commented Jun 20, 2014

Okay, I see what the problem is, fixing...

PaulBender added a commit that referenced this issue Jun 20, 2014

Working on #688 Expand Forum Moderator permissions
Fixed unapproved and deleted permissions with posts

PaulBender added a commit that referenced this issue Jun 20, 2014

Working on #688 Expand Forum Moderator permissions
Missed some permissions on the postbit(s)
@Sama34

This comment has been minimized.

Show comment
Hide comment
@Sama34

Sama34 Jun 21, 2014

Contributor

Did you only added per-moderator permissions or per-group and/or per-forum too?

Contributor

Sama34 commented Jun 21, 2014

Did you only added per-moderator permissions or per-group and/or per-forum too?

@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 22, 2014

Member

It's just per moderator permissions I added

Member

PaulBender commented Jun 22, 2014

It's just per moderator permissions I added

@Sama34

This comment has been minimized.

Show comment
Hide comment
@Sama34

Sama34 Jun 22, 2014

Contributor

Do you plan on adding per-group ones like "Can manage annoucements"? I thought you already did.

Contributor

Sama34 commented Jun 22, 2014

Do you plan on adding per-group ones like "Can manage annoucements"? I thought you already did.

@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 22, 2014

Member

I added some Mod CP permissions in the moderator permissions (the ones that can be regulated per forum, like announcements, mod queue, reported posts and viewing the mod log). I will add per-group ones right now.

Member

PaulBender commented Jun 22, 2014

I added some Mod CP permissions in the moderator permissions (the ones that can be regulated per forum, like announcements, mod queue, reported posts and viewing the mod log). I will add per-group ones right now.

PaulBender added a commit that referenced this issue Jun 22, 2014

Working on #688 Expand Forum Moderator permissions
Added permissions to the Mod CP
@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 22, 2014

Member

That adds a group-based permission scheme to the Mod CP

Member

PaulBender commented Jun 22, 2014

That adds a group-based permission scheme to the Mod CP

PaulBender added a commit that referenced this issue Jun 22, 2014

Working on #688 Expand Forum Moderator permissions
Mod CP permissions for the profile Mod CP links
Added model pop-up for user notes if over cutoff
@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 22, 2014

Member

This commit adds the new Mod CP permissions for the profile Mod CP links (forgot about them)

It also adds model pop-up to view all user notes if notes are longer than the 100 characters cutoff.

Member

PaulBender commented Jun 22, 2014

This commit adds the new Mod CP permissions for the profile Mod CP links (forgot about them)

It also adds model pop-up to view all user notes if notes are longer than the 100 characters cutoff.

PaulBender added a commit that referenced this issue Jun 22, 2014

Working on #688 Expand Forum Moderator permissions
Last remaining Mod CP locations now use Mod CP permissions
@xykul

This comment has been minimized.

Show comment
Hide comment
@xykul

xykul Jun 22, 2014

Not displayed.. does not work.
modcp

modcp2

xykul commented Jun 22, 2014

Not displayed.. does not work.
modcp

modcp2

@Destroy666x

This comment has been minimized.

Show comment
Hide comment
@Destroy666x

Destroy666x Jun 22, 2014

Contributor

@xykul, does your account have group with Super Moderator permission? If not, you have to report/log/unapprove something in assigned forum(s) to see the menu. Not sure why, I don't think it should be like this.

EDIT: it's actually more complicated and messy than I thought - right now single forum user moderators lose their functionality because they have to be in a group which has these permissions.

Contributor

Destroy666x commented Jun 22, 2014

@xykul, does your account have group with Super Moderator permission? If not, you have to report/log/unapprove something in assigned forum(s) to see the menu. Not sure why, I don't think it should be like this.

EDIT: it's actually more complicated and messy than I thought - right now single forum user moderators lose their functionality because they have to be in a group which has these permissions.

@xykul

This comment has been minimized.

Show comment
Hide comment
@xykul

xykul Jun 22, 2014

Moderators group
modcp.php
210, && $mybb->usergroup['canmanageannounce'] == 1)
215, && $mybb->usergroup['canmanagemodqueue'] == 1)
220, && $mybb->usergroup['canmanagereportedcontent'] == 1)
225, && $mybb->usergroup['canviewmodlogs'] == 1)
lines can not be valid.

xykul commented Jun 22, 2014

Moderators group
modcp.php
210, && $mybb->usergroup['canmanageannounce'] == 1)
215, && $mybb->usergroup['canmanagemodqueue'] == 1)
220, && $mybb->usergroup['canmanagereportedcontent'] == 1)
225, && $mybb->usergroup['canviewmodlogs'] == 1)
lines can not be valid.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 29, 2014

Contributor

@PaulBender this is urgent as you have committed directly.

Contributor

PirataNervo commented Jun 29, 2014

@PaulBender this is urgent as you have committed directly.

@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 29, 2014

Member

Not quite sure what the problem is. If a user isn't a super moderator they must be assigned to at least one forum in order to see the options in the Forums & Posts menu. Otherwise I'd be showing them links that go nowhere.

I should add a notice in the Admin CP making it clear to Admins that it works that way.

Member

PaulBender commented Jun 29, 2014

Not quite sure what the problem is. If a user isn't a super moderator they must be assigned to at least one forum in order to see the options in the Forums & Posts menu. Otherwise I'd be showing them links that go nowhere.

I should add a notice in the Admin CP making it clear to Admins that it works that way.

PaulBender added a commit that referenced this issue Jun 29, 2014

Working on #688 Expand Forum Moderator permissions
Added notices in the Admin CP telling uses how the system works
@Destroy666x

This comment has been minimized.

Show comment
Hide comment
@Destroy666x

Destroy666x Jun 29, 2014

Contributor
  1. Assign moderator X to a forum, leave him in Registered group which doesn't have these permissions ticked.
  2. Single moderator can't see anything from his forum even though forum-specific "Moderator CP Permissions" allow him to do it. You have to move him to other group first.

Doesn't make any sense for me.

Contributor

Destroy666x commented Jun 29, 2014

  1. Assign moderator X to a forum, leave him in Registered group which doesn't have these permissions ticked.
  2. Single moderator can't see anything from his forum even though forum-specific "Moderator CP Permissions" allow him to do it. You have to move him to other group first.

Doesn't make any sense for me.

@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 29, 2014

Member

The Registered group shouldn't have access to the Mod CP at all. If a mod is being left in the Registered group, or any group that doesn't have permission to access the Mod CP, they shouldn't access anything in the Mod CP, period.

Member

PaulBender commented Jun 29, 2014

The Registered group shouldn't have access to the Mod CP at all. If a mod is being left in the Registered group, or any group that doesn't have permission to access the Mod CP, they shouldn't access anything in the Mod CP, period.

@Destroy666x

This comment has been minimized.

Show comment
Hide comment
@Destroy666x

Destroy666x Jun 29, 2014

Contributor

Well then, fair enough. I thought the moderator system was confusing already, now it's even more. But whatever, 'period'.

Contributor

Destroy666x commented Jun 29, 2014

Well then, fair enough. I thought the moderator system was confusing already, now it's even more. But whatever, 'period'.

@Sama34

This comment has been minimized.

Show comment
Hide comment
@Sama34

Sama34 Jun 29, 2014

Contributor

@PaulBender Assigning an user as moderator to X forum doesn't behave the same that assigning a group to it. Probably it should be modified to work the same way. Currently single moderators are allowed to enter the ModCP regardless of their group permissions.

@Destroy666x, I think per-group permission should override per-moderator ones as it currently does (they may be moderate posts/content but cannot access the ModCP, which the permissions aim to control). But yeah, MyBB is confusing at some parts.

Contributor

Sama34 commented Jun 29, 2014

@PaulBender Assigning an user as moderator to X forum doesn't behave the same that assigning a group to it. Probably it should be modified to work the same way. Currently single moderators are allowed to enter the ModCP regardless of their group permissions.

@Destroy666x, I think per-group permission should override per-moderator ones as it currently does (they may be moderate posts/content but cannot access the ModCP, which the permissions aim to control). But yeah, MyBB is confusing at some parts.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 29, 2014

Contributor

I agree with @Sama34

Contributor

PirataNervo commented Jun 29, 2014

I agree with @Sama34

@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 29, 2014

Member

@Sama34 You sure? When I assigned a user to moderate a forum and made sure that they were in a group that can't access the Mod CP, I got a You do not have permission to access this page. error everywhere in the Mod CP.

modcp.php checks to see if you have the Can access Mod CP group permission first and throws an error if you don't have it (or you're a guest).

I agree that per-group permission should override per-moderator permission (the per-moderator permission was really intended to control ability to use that function for the forum the moderator is assigned to).

Member

PaulBender commented Jun 29, 2014

@Sama34 You sure? When I assigned a user to moderate a forum and made sure that they were in a group that can't access the Mod CP, I got a You do not have permission to access this page. error everywhere in the Mod CP.

modcp.php checks to see if you have the Can access Mod CP group permission first and throws an error if you don't have it (or you're a guest).

I agree that per-group permission should override per-moderator permission (the per-moderator permission was really intended to control ability to use that function for the forum the moderator is assigned to).

PaulBender added a commit that referenced this issue Jun 29, 2014

Working on #688 Expand Forum Moderator permissions
Updated descriptions for moderator permissions dealing with the Mod CP permissions.
@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 29, 2014

Member

I updated the descriptions for the moderator permissions dealing with the Mod CP permissions to make it clear that they only apply for that forum.

Member

PaulBender commented Jun 29, 2014

I updated the descriptions for the moderator permissions dealing with the Mod CP permissions to make it clear that they only apply for that forum.

@Sama34

This comment has been minimized.

Show comment
Hide comment
@Sama34

Sama34 Jun 29, 2014

Contributor

Never mind, the reason is the user being moved to the "Moderators" groups when assigned as a single forum moderator. No sure why it works like this.

Contributor

Sama34 commented Jun 29, 2014

Never mind, the reason is the user being moved to the "Moderators" groups when assigned as a single forum moderator. No sure why it works like this.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 30, 2014

Contributor

Closing this.

Contributor

PirataNervo commented Jun 30, 2014

Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment