Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit stylesheet #699

Closed
DiogoParrinha opened this issue Jun 3, 2014 · 16 comments
Closed

Edit stylesheet #699

DiogoParrinha opened this issue Jun 3, 2014 · 16 comments
Assignees
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Milestone

Comments

@DiogoParrinha
Copy link
Contributor

In 1.6 when you edit stylesheets and your done, you save it and it stays on that stylesheet, but in 1.8 you save it and it resets itself back to container, it's a little annoying when your editing that stylesheet and you have to go search for it again, is that how it was intended or is that a bug?

Original thread: Edit stylesheet

@JonathanP89
Copy link

Maybe someone else can try and reproduce it so we know if it's a bug or not.

@Starpaul20
Copy link
Member

I've reproduced it, it's definitely a bug.

@PenguinPaul
Copy link
Contributor

I cannot reproduce.

@Destroy666x
Copy link
Contributor

@PenguinPaul:

  1. Edit global.css or other stylesheet
  2. Stay at Edit Stylesheet: Simple Mode tab
  3. Select .error_message or any other selector from dropdown
  4. Save Changes (with or without editing, doesn't matter)
  5. In 1.6.13 it stays on .error_message selector (or the one you chose), in 1.8 b1 it switches back to #container

So it's surely a bug.

@PenguinPaul
Copy link
Contributor

@Destroy666x Ah, I misunderstood the bug. Whoops.

JordanMussi added a commit that referenced this issue Jun 4, 2014
@JordanMussi
Copy link
Contributor

I've merged that pull. However the jGrowl message is saving..., I feel it should be Saving... for consistency.

@ATofighi
Copy link
Contributor

ATofighi commented Jun 4, 2014

@JordanMussi please see #725

@DiogoParrinha DiogoParrinha added this to the 1.8 Beta 2 milestone Jun 7, 2014
@DiogoParrinha
Copy link
Contributor Author

@ATofighi your PR MUST use language variables. Please submit a new PR to fix it.
@JordanMussi make sure not to miss that next time please! :)

@JordanMussi
Copy link
Contributor

The pull didn't make the change (didn't make it an issue) so I saw no harm in merging it. However I should have mentioned it in the js language conversion ticket.

@JonathanP89
Copy link

This still happens in 1.8 by the way.

@Destroy666x Destroy666x modified the milestones: 1.8.1, 1.8 Beta 2 Sep 4, 2014
@Destroy666x
Copy link
Contributor

Yep, the issue is still present.

@JonathanP89
Copy link

I fixed it with the commits above and it's working now for me at least.

@JonathanP89
Copy link

This could be closed, it works for me after doing those commits.

@Destroy666x
Copy link
Contributor

It can't be closed because the issue is still present in MyBB and you fixed it only in your installation... These commits worked fine before but they were apparently reverted by one of PRs. So they need to be applied again.

@JonathanP89
Copy link

That's what i meant

@DiogoParrinha DiogoParrinha removed this from the 1.8.1 milestone Oct 4, 2014
@DiogoParrinha DiogoParrinha modified the milestones: 1.8.2, 1.8.1 Oct 4, 2014
@ATofighi
Copy link
Contributor

Fixed in #1551

@ATofighi ATofighi self-assigned this Oct 27, 2014
@ATofighi ATofighi added the s:resolved Status: Resolved. Solution implemented or scheduled label Oct 27, 2014
@ATofighi ATofighi removed s:confirmed Status: Confirmed. Retested and found the issue exists p:medium Priority: Medium. Issues to be resolved with normal preference labels Dec 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:bug Type: Bug. An issue causing error / flaw / malfunction
Projects
None yet
Development

No branches or pull requests

7 participants