Overqualified Selectors

[DiogoParrinha]

Fix CSS selectors. (see original thread for list - I'll post it here when I work on this)

Original thread: Overqualified Selectors

[Eric-Jackson]

I want to attempt to work on this, but I'm new to git so if I do something wrong my bad. 💃

[Eric-Jackson]

Well those are taken care of, I'll try and look into the others.

[Eric-Jackson]

Just looking through these files, inline_moderation.js and the related controls in templates are extremely strict, which really limits the theme developers. I don't know github/mybb guidelines well enough to know if I should attempt a fix at that here, or start another branch/issue to keep them separate (It's still relating to selectors and lack of classes). Or if I should fix it at all for that matter.

[DiogoParrinha]

I'll go through these soon and try to get them into MyBB 1.8 Beta 2. After we can work on improving the JS files.

[DiogoParrinha]

@Eric-Jackson can you please update your PR? There are conflicts and I can't merge it. I've also commented on a line there which I believe you made a mistake.

[Eric-Jackson]

@PirataNervo I don't know how to update it yet, I'll try to figure it out though. But there's no error, the code is still there. I've only changed the selector.

[DiogoParrinha]

@Eric-Jackson conflicts mean that the PR cannot be merged automatically because other changes have been made meanwhile and the difference generated bit GH at the time you submitted your PR can no longer be applied. You either resolve the conflicts yourself or (if you don't know how to do it) you submit a new PR by creating the changes again.

[Eric-Jackson]

@PirataNervo Alright I've created a new branch and pull request.

[DiogoParrinha]

Thanks, I've commented on a line.

[Eric-Jackson]

The elements were .each() looped twice, once for div.trow_selected and once for td.trow_selected. Both times removing .trow_selected. By simplifying those selectors, the loops become the same code, so I removed one block of it.

[DiogoParrinha]

Alright, removed my comment. Apparently I missed the lines just below that. Thank you! Going to test it now.

[DiogoParrinha]

Merged! I'm closing this now. Or are there any others you'd like to work on?

[Eric-Jackson]

There are some more things I'd like to work on, but they aren't "Overqualified selectors", just "Strict element targeting". Maybe that would be best in another issue.

[DiogoParrinha]

Alright, closing this. Feel free to open a new issue on the forums :)

[Stefan-MyBB]

These changes introduced invalid HTML:

document type does not allow element "div" here; missing one of "object", "applet", "map", "iframe", "button", "ins", "del" start-tag

<dt><div class="forum_status forum_on" title="Forum Contains New Posts"></div></dt>

[Destroy666x]

Changing the forum legend <div>s to <span>s with style="display: inline-block;" should fix it.

[ATofighi]

Fixed in #1299

[Sama34]

Seems fixed to me.