Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overqualified Selectors #700

Closed
DiogoParrinha opened this issue Jun 3, 2014 · 18 comments
Closed

Overqualified Selectors #700

DiogoParrinha opened this issue Jun 3, 2014 · 18 comments

Comments

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jun 3, 2014

Fix CSS selectors. (see original thread for list - I'll post it here when I work on this)

Original thread: Overqualified Selectors

@DiogoParrinha DiogoParrinha added this to the 1.8 Beta 2 milestone Jun 3, 2014
@DiogoParrinha DiogoParrinha added 1.8 and removed bug labels Jun 3, 2014
@Eric-Jackson
Copy link
Contributor

@Eric-Jackson Eric-Jackson commented Jun 3, 2014

I want to attempt to work on this, but I'm new to git so if I do something wrong my bad. 💃

@Eric-Jackson
Copy link
Contributor

@Eric-Jackson Eric-Jackson commented Jun 3, 2014

Well those are taken care of, I'll try and look into the others.

@Eric-Jackson
Copy link
Contributor

@Eric-Jackson Eric-Jackson commented Jun 4, 2014

Just looking through these files, inline_moderation.js and the related controls in templates are extremely strict, which really limits the theme developers. I don't know github/mybb guidelines well enough to know if I should attempt a fix at that here, or start another branch/issue to keep them separate (It's still relating to selectors and lack of classes). Or if I should fix it at all for that matter.

@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jun 26, 2014

I'll go through these soon and try to get them into MyBB 1.8 Beta 2. After we can work on improving the JS files.

@DiogoParrinha DiogoParrinha self-assigned this Jun 26, 2014
DiogoParrinha pushed a commit that referenced this issue Jun 28, 2014
Working on #700 - Overqualified Selectors
@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jun 28, 2014

@Eric-Jackson can you please update your PR? There are conflicts and I can't merge it. I've also commented on a line there which I believe you made a mistake.

@Eric-Jackson
Copy link
Contributor

@Eric-Jackson Eric-Jackson commented Jun 28, 2014

@PirataNervo I don't know how to update it yet, I'll try to figure it out though. But there's no error, the code is still there. I've only changed the selector.

@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jun 28, 2014

@Eric-Jackson conflicts mean that the PR cannot be merged automatically because other changes have been made meanwhile and the difference generated bit GH at the time you submitted your PR can no longer be applied. You either resolve the conflicts yourself or (if you don't know how to do it) you submit a new PR by creating the changes again.

@Eric-Jackson
Copy link
Contributor

@Eric-Jackson Eric-Jackson commented Jun 28, 2014

@PirataNervo Alright I've created a new branch and pull request.

@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jun 28, 2014

Thanks, I've commented on a line.

@Eric-Jackson
Copy link
Contributor

@Eric-Jackson Eric-Jackson commented Jun 28, 2014

The elements were .each() looped twice, once for div.trow_selected and once for td.trow_selected. Both times removing .trow_selected. By simplifying those selectors, the loops become the same code, so I removed one block of it.

@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jun 28, 2014

Alright, removed my comment. Apparently I missed the lines just below that. Thank you! Going to test it now.

@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jun 28, 2014

Merged! I'm closing this now. Or are there any others you'd like to work on?

@DiogoParrinha DiogoParrinha added the fixed label Jun 28, 2014
@Eric-Jackson
Copy link
Contributor

@Eric-Jackson Eric-Jackson commented Jun 28, 2014

There are some more things I'd like to work on, but they aren't "Overqualified selectors", just "Strict element targeting". Maybe that would be best in another issue.

@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jun 28, 2014

Alright, closing this. Feel free to open a new issue on the forums :)

@Stefan-ST
Copy link
Contributor

@Stefan-ST Stefan-ST commented Aug 23, 2014

These changes introduced invalid HTML:

document type does not allow element "div" here; missing one of "object", "applet", "map", "iframe", "button", "ins", "del" start-tag

<dt><div class="forum_status forum_on" title="Forum Contains New Posts"></div></dt>
@Stefan-ST Stefan-ST reopened this Aug 23, 2014
@Stefan-ST Stefan-ST modified the milestones: 1.8 Beta 2, 1.8.0 Aug 23, 2014
@Stefan-ST Stefan-ST added s:feedback and removed s:fixed labels Aug 23, 2014
@Destroy666x
Copy link
Contributor

@Destroy666x Destroy666x commented Aug 23, 2014

Changing the forum legend <div>s to <span>s with style="display: inline-block;" should fix it.

ATofighi added a commit to ATofighi/mybb_ that referenced this issue Aug 23, 2014
@ATofighi
Copy link
Contributor

@ATofighi ATofighi commented Aug 23, 2014

Fixed in #1299

Sama34 added a commit that referenced this issue Aug 23, 2014
@Sama34
Copy link
Contributor

@Sama34 Sama34 commented Aug 23, 2014

Seems fixed to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

6 participants
You can’t perform that action at this time.