-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACP shouldn't reset $mybb->input #754
Comments
@Sama34 if we're doing this it must be in Beta 2, unless you test this heavily when implementing in Beta 3. |
@Sama34 are you going to get time to do this today/tomorrow? if not, I'll take it on tomorrow. |
@euantorano please work on it, Sama has other more important issues to work on. I've just assigned this to you. |
This shouldn't be hard to fix, just make sure array_merge() works as expected, if everything goes fine only 25 lines need to be updated :D |
#814 should fix all instances of this in the ACP using |
Merged your PR. Haven't tested it, only went through your changes. Any bugs should be reported during Beta 2 testing period or tomorrow of course. |
I assume you didn't mean to re-open this @PirataNervo? |
@euantorano please see my comment in #814 |
Check ./admin/modules/user/users.php Line#175:
We should use array_merge() or update the code.
This is repeated 25 times in the ACP.
Internal discussion: http://community.mybb.com/thread-153592.html
The text was updated successfully, but these errors were encountered: