New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACP shouldn't reset $mybb->input #754

Closed
Sama34 opened this Issue Jun 15, 2014 · 8 comments

Comments

Projects
None yet
6 participants
@Sama34
Contributor

Sama34 commented Jun 15, 2014

Check ./admin/modules/user/users.php Line#175:

$mybb->input = $usertitle; 

We should use array_merge() or update the code.

This is repeated 25 times in the ACP.

Internal discussion: http://community.mybb.com/thread-153592.html

@Sama34 Sama34 added this to the 1.8 Beta 2 milestone Jun 15, 2014

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 27, 2014

Contributor

@Sama34 if we're doing this it must be in Beta 2, unless you test this heavily when implementing in Beta 3.

Contributor

PirataNervo commented Jun 27, 2014

@Sama34 if we're doing this it must be in Beta 2, unless you test this heavily when implementing in Beta 3.

@euantorano

This comment has been minimized.

Show comment
Hide comment
@euantorano

euantorano Jun 28, 2014

Member

@Sama34 are you going to get time to do this today/tomorrow? if not, I'll take it on tomorrow.

Member

euantorano commented Jun 28, 2014

@Sama34 are you going to get time to do this today/tomorrow? if not, I'll take it on tomorrow.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 28, 2014

Contributor

@euantorano please work on it, Sama has other more important issues to work on. I've just assigned this to you.

Contributor

PirataNervo commented Jun 28, 2014

@euantorano please work on it, Sama has other more important issues to work on. I've just assigned this to you.

@PirataNervo PirataNervo assigned euantorano and unassigned Sama34 Jun 28, 2014

@Sama34

This comment has been minimized.

Show comment
Hide comment
@Sama34

Sama34 Jun 28, 2014

Contributor

This shouldn't be hard to fix, just make sure array_merge() works as expected, if everything goes fine only 25 lines need to be updated :D

Contributor

Sama34 commented Jun 28, 2014

This shouldn't be hard to fix, just make sure array_merge() works as expected, if everything goes fine only 25 lines need to be updated :D

@euantorano

This comment has been minimized.

Show comment
Hide comment
@euantorano

euantorano Jun 29, 2014

Member

#814 should fix all instances of this in the ACP using array_merge().

Member

euantorano commented Jun 29, 2014

#814 should fix all instances of this in the ACP using array_merge().

@PirataNervo PirataNervo referenced this issue Jun 29, 2014

Merged

Fixing #574 #814

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 29, 2014

Contributor

Merged your PR. Haven't tested it, only went through your changes. Any bugs should be reported during Beta 2 testing period or tomorrow of course.

Contributor

PirataNervo commented Jun 29, 2014

Merged your PR. Haven't tested it, only went through your changes. Any bugs should be reported during Beta 2 testing period or tomorrow of course.

@euantorano

This comment has been minimized.

Show comment
Hide comment
@euantorano

euantorano Jun 29, 2014

Member

I assume you didn't mean to re-open this @PirataNervo?

Member

euantorano commented Jun 29, 2014

I assume you didn't mean to re-open this @PirataNervo?

@euantorano euantorano closed this Jun 29, 2014

@ATofighi

This comment has been minimized.

Show comment
Hide comment
@ATofighi

ATofighi Jun 29, 2014

Contributor

@euantorano please see my comment in #814

Contributor

ATofighi commented Jun 29, 2014

@euantorano please see my comment in #814

euantorano added a commit that referenced this issue Jun 29, 2014

Merge pull request #823 from euantorano/featurefix-754
Fixing #754 by re-ordering parameters to array_merge based on @Sama34's suggestions.

@Sama34 Sama34 assigned PaulBender and unassigned euantorano Jul 5, 2014

@JordanMussi JordanMussi removed the feedback label Jul 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment