Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACP shouldn't reset $mybb->input #754

Closed
Sama34 opened this issue Jun 15, 2014 · 8 comments
Closed

ACP shouldn't reset $mybb->input #754

Sama34 opened this issue Jun 15, 2014 · 8 comments
Assignees
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:enhancement Type: Enhancement. Contains minor improvements
Milestone

Comments

@Sama34
Copy link
Contributor

Sama34 commented Jun 15, 2014

Check ./admin/modules/user/users.php Line#175:

$mybb->input = $usertitle; 

We should use array_merge() or update the code.

This is repeated 25 times in the ACP.

Internal discussion: http://community.mybb.com/thread-153592.html

@DiogoParrinha
Copy link
Contributor

DiogoParrinha commented Jun 27, 2014

@Sama34 if we're doing this it must be in Beta 2, unless you test this heavily when implementing in Beta 3.

@euantorano
Copy link
Member

euantorano commented Jun 28, 2014

@Sama34 are you going to get time to do this today/tomorrow? if not, I'll take it on tomorrow.

@DiogoParrinha
Copy link
Contributor

DiogoParrinha commented Jun 28, 2014

@euantorano please work on it, Sama has other more important issues to work on. I've just assigned this to you.

@DiogoParrinha DiogoParrinha assigned euantorano and unassigned Sama34 Jun 28, 2014
@Sama34
Copy link
Contributor Author

Sama34 commented Jun 28, 2014

This shouldn't be hard to fix, just make sure array_merge() works as expected, if everything goes fine only 25 lines need to be updated :D

@euantorano
Copy link
Member

euantorano commented Jun 29, 2014

#814 should fix all instances of this in the ACP using array_merge().

@DiogoParrinha
Copy link
Contributor

DiogoParrinha commented Jun 29, 2014

Merged your PR. Haven't tested it, only went through your changes. Any bugs should be reported during Beta 2 testing period or tomorrow of course.

@euantorano
Copy link
Member

euantorano commented Jun 29, 2014

I assume you didn't mean to re-open this @PirataNervo?

@ATofighi
Copy link
Contributor

ATofighi commented Jun 29, 2014

@euantorano please see my comment in #814

euantorano added a commit that referenced this issue Jun 29, 2014
Fixing #754 by re-ordering parameters to array_merge based on @Sama34's suggestions.
@Sama34 Sama34 assigned Starpaul20 and unassigned euantorano Jul 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:enhancement Type: Enhancement. Contains minor improvements
Projects
None yet
Development

No branches or pull requests

6 participants