New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Time Zones #764

Closed
PaulBender opened this Issue Jun 20, 2014 · 6 comments

Comments

Projects
None yet
3 participants
@PaulBender
Member

PaulBender commented Jun 20, 2014

Several official time zones, such as UTC-9:30, UTC+05:45, UTC+06:30, UTC+10:30, UTC+11:30, UTC+12:45, UTC+13:00 and UTC+14:00 are missing and should be added.

Also need to fix a bug where :45 timezone appear as :75 in the time zone drop down.

@PaulBender PaulBender added this to the 1.8 Beta 2 milestone Jun 20, 2014

@PaulBender PaulBender self-assigned this Jun 20, 2014

PaulBender added a commit that referenced this issue Jun 20, 2014

@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 20, 2014

Member

Finished

Member

PaulBender commented Jun 20, 2014

Finished

@PaulBender PaulBender added the fixed label Jun 20, 2014

PaulBender added a commit that referenced this issue Jun 20, 2014

Feature #764 Add Time Zones
Added setting upgrade routine and updated time zone city list
@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 24, 2014

Contributor

I can confirm this to be working.

Contributor

PirataNervo commented Jun 24, 2014

I can confirm this to be working.

@Destroy666x

This comment has been minimized.

Show comment
Hide comment
@Destroy666x

Destroy666x Jun 24, 2014

Contributor
$l['timezone_gmt_200'] = "(GMT +2:00) Athens, Istanbul, Cairo, Jerusalem, South Africa, Warsaw";

Warsaw (like whole Poland) has CET, so it's GMT + 1 without summer time like in Berlin, Copenhagen etc. We never have the same time as Greece. This need to be corrected. Not sure if the rest is correct, but probably it needs to be checked.

BTW, is there any reason why the short GMT list is used UCP options and the long list in ACP edit user? I think both should be long.

Contributor

Destroy666x commented Jun 24, 2014

$l['timezone_gmt_200'] = "(GMT +2:00) Athens, Istanbul, Cairo, Jerusalem, South Africa, Warsaw";

Warsaw (like whole Poland) has CET, so it's GMT + 1 without summer time like in Berlin, Copenhagen etc. We never have the same time as Greece. This need to be corrected. Not sure if the rest is correct, but probably it needs to be checked.

BTW, is there any reason why the short GMT list is used UCP options and the long list in ACP edit user? I think both should be long.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo
Contributor

PirataNervo commented Jun 24, 2014

@PirataNervo PirataNervo reopened this Jun 24, 2014

PaulBender added a commit that referenced this issue Jun 24, 2014

Feature #764 Add Time Zones
Updated time zone list
@PaulBender

This comment has been minimized.

Show comment
Hide comment
@PaulBender

PaulBender Jun 24, 2014

Member

Okay, I've updated the entire list. All cities/countries listed should be correct.

Member

PaulBender commented Jun 24, 2014

Okay, I've updated the entire list. All cities/countries listed should be correct.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 24, 2014

Contributor

Awesome.

Contributor

PirataNervo commented Jun 24, 2014

Awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment