CDN Compatibility #776

Closed
PirataNervo opened this Issue Jun 24, 2014 · 8 comments

Comments

Projects
None yet
5 participants
@PirataNervo
Contributor

PirataNervo commented Jun 24, 2014

Pull request: #64

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 25, 2014

Contributor

This is now finished.

Contributor

PirataNervo commented Jun 25, 2014

This is now finished.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 26, 2014

Contributor

@euantorano there is a bug here:
global.php


if(!empty($theme_stylesheets))
{
    foreach($theme['disporder'] as $style_name => $order)
    {
        if(!empty($theme_stylesheets[$style_name]))
        {
            $stylesheets .= $theme_stylesheets[$style_name];
        }
    }
}

Example of $theme_stylesheets array:

Array
(
    [css.php?stylesheet=18] => '<link href="http://localhost/mybb18/feature-mysql/css.php?stylesheet=18" rel="stylesheet" type="text/css">'
    [css.php?stylesheet=7] => '<link href="http://localhost/mybb18/feature-mysql/css.php?stylesheet=7" rel="stylesheet" type="text/css">'
)

Example of $style_name:
global.css

As you can see, it will never build the $stylesheets variable. This is rather urgent and apparently I missed this when merging your PR, I probably forgot to apply a change somewhere.

Contributor

PirataNervo commented Jun 26, 2014

@euantorano there is a bug here:
global.php


if(!empty($theme_stylesheets))
{
    foreach($theme['disporder'] as $style_name => $order)
    {
        if(!empty($theme_stylesheets[$style_name]))
        {
            $stylesheets .= $theme_stylesheets[$style_name];
        }
    }
}

Example of $theme_stylesheets array:

Array
(
    [css.php?stylesheet=18] => '<link href="http://localhost/mybb18/feature-mysql/css.php?stylesheet=18" rel="stylesheet" type="text/css">'
    [css.php?stylesheet=7] => '<link href="http://localhost/mybb18/feature-mysql/css.php?stylesheet=7" rel="stylesheet" type="text/css">'
)

Example of $style_name:
global.css

As you can see, it will never build the $stylesheets variable. This is rather urgent and apparently I missed this when merging your PR, I probably forgot to apply a change somewhere.

@euantorano

This comment has been minimized.

Show comment
Hide comment
@euantorano

euantorano Jun 26, 2014

Member

Oh dear, that is quite a large bug. I'll fix it tonight - should be a simple fix.

On 26 Jun 2014, at 01:08, Diogo Parrinha notifications@github.com wrote:

@euantorano there is a bug here:
global.php

if(!empty($theme_stylesheets))
{
foreach($theme['disporder'] as $style_name => $order)
{
if(!empty($theme_stylesheets[$style_name]))
{
$stylesheets .= $theme_stylesheets[$style_name];
}
}
}
Example of $theme_stylesheets array:

Array
(
[css.php?stylesheet=18] => ''
[css.php?stylesheet=7] => ''
)
Example of $style_name:
global.css

As you can see, it will never build the $stylesheets variable. This is rather urgent and apparently I missed this when merging your PR, I probably forgot to apply a change somewhere.


Reply to this email directly or view it on GitHub.

Member

euantorano commented Jun 26, 2014

Oh dear, that is quite a large bug. I'll fix it tonight - should be a simple fix.

On 26 Jun 2014, at 01:08, Diogo Parrinha notifications@github.com wrote:

@euantorano there is a bug here:
global.php

if(!empty($theme_stylesheets))
{
foreach($theme['disporder'] as $style_name => $order)
{
if(!empty($theme_stylesheets[$style_name]))
{
$stylesheets .= $theme_stylesheets[$style_name];
}
}
}
Example of $theme_stylesheets array:

Array
(
[css.php?stylesheet=18] => ''
[css.php?stylesheet=7] => ''
)
Example of $style_name:
global.css

As you can see, it will never build the $stylesheets variable. This is rather urgent and apparently I missed this when merging your PR, I probably forgot to apply a change somewhere.


Reply to this email directly or view it on GitHub.

@euantorano

This comment has been minimized.

Show comment
Hide comment
@euantorano

euantorano Jun 26, 2014

Member

@PirataNervo I think the issue you're talking about is #734 which I reported here: http://community.mybb.com/thread-154565.html

@JN-Jones was going to look at this. Did you make any progress?

Either way, you made me notice I wasn't handling css.php for when it finally gets fixed, so I've now added that.

Member

euantorano commented Jun 26, 2014

@PirataNervo I think the issue you're talking about is #734 which I reported here: http://community.mybb.com/thread-154565.html

@JN-Jones was going to look at this. Did you make any progress?

Either way, you made me notice I wasn't handling css.php for when it finally gets fixed, so I've now added that.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 26, 2014

Contributor

@euantorano yes it might not be related to this, but I noticed it after this only :P

Contributor

PirataNervo commented Jun 26, 2014

@euantorano yes it might not be related to this, but I noticed it after this only :P

@euantorano

This comment has been minimized.

Show comment
Hide comment
@euantorano

euantorano Jun 26, 2014

Member

It could well be related, but we'll see if the other patch fixes it 😉

Member

euantorano commented Jun 26, 2014

It could well be related, but we'll see if the other patch fixes it 😉

@Eldenroot

This comment has been minimized.

Show comment
Hide comment
@Eldenroot

Eldenroot Jun 28, 2014

Contributor

Thanks,,, keep good work!

Contributor

Eldenroot commented Jun 28, 2014

Thanks,,, keep good work!

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jun 28, 2014

Contributor

Closing this. Any bugs should be reported during Beta 2 testing period.

Contributor

PirataNervo commented Jun 28, 2014

Closing this. Any bugs should be reported during Beta 2 testing period.

euantorano added a commit that referenced this issue Jun 30, 2014

Merge pull request #826 from euantorano/featurefix-776
Changing upload_file() to also upload to CDN if enabled as part of #776.

@Sama34 Sama34 assigned PaulBender and unassigned euantorano Jul 5, 2014

@JordanMussi JordanMussi removed the feedback label Jul 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment