CDN Compatibility

[DiogoParrinha]

Pull request: #64

[DiogoParrinha]

This is now finished.

[DiogoParrinha]

@euantorano there is a bug here:
global.php

if(!empty($theme_stylesheets))
{
    foreach($theme['disporder'] as $style_name => $order)
    {
        if(!empty($theme_stylesheets[$style_name]))
        {
            $stylesheets .= $theme_stylesheets[$style_name];
        }
    }
}

Example of $theme_stylesheets array:

Array
(
    [css.php?stylesheet=18] => '<link href="http://localhost/mybb18/feature-mysql/css.php?stylesheet=18" rel="stylesheet" type="text/css">'
    [css.php?stylesheet=7] => '<link href="http://localhost/mybb18/feature-mysql/css.php?stylesheet=7" rel="stylesheet" type="text/css">'
)

Example of $style_name:
global.css

As you can see, it will never build the $stylesheets variable. This is rather urgent and apparently I missed this when merging your PR, I probably forgot to apply a change somewhere.

[euantorano]

Oh dear, that is quite a large bug. I'll fix it tonight - should be a simple fix.

On 26 Jun 2014, at 01:08, Diogo Parrinha notifications@github.com wrote:

@euantorano there is a bug here:
global.php

if(!empty($theme_stylesheets))
{
foreach($theme['disporder'] as $style_name => $order)
{
if(!empty($theme_stylesheets[$style_name]))
{
$stylesheets .= $theme_stylesheets[$style_name];
}
}
}
Example of $theme_stylesheets array:

Array
(
[css.php?stylesheet=18] => ''
[css.php?stylesheet=7] => ''
)
Example of $style_name:
global.css

As you can see, it will never build the $stylesheets variable. This is rather urgent and apparently I missed this when merging your PR, I probably forgot to apply a change somewhere.

—
Reply to this email directly or view it on GitHub.

[euantorano]

@PirataNervo I think the issue you're talking about is #734 which I reported here: http://community.mybb.com/thread-154565.html

@JN-Jones was going to look at this. Did you make any progress?

Either way, you made me notice I wasn't handling css.php for when it finally gets fixed, so I've now added that.

[DiogoParrinha]

@euantorano yes it might not be related to this, but I noticed it after this only :P

[euantorano]

It could well be related, but we'll see if the other patch fixes it 😉

[Eldenroot]

Thanks,,, keep good work!

[DiogoParrinha]

Closing this. Any bugs should be reported during Beta 2 testing period.