Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDN Compatibility #776

Closed
DiogoParrinha opened this issue Jun 24, 2014 · 8 comments
Closed

CDN Compatibility #776

DiogoParrinha opened this issue Jun 24, 2014 · 8 comments
Assignees
Milestone

Comments

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jun 24, 2014

Pull request: #64

@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jun 25, 2014

This is now finished.

@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jun 26, 2014

@euantorano there is a bug here:
global.php

if(!empty($theme_stylesheets))
{
    foreach($theme['disporder'] as $style_name => $order)
    {
        if(!empty($theme_stylesheets[$style_name]))
        {
            $stylesheets .= $theme_stylesheets[$style_name];
        }
    }
}

Example of $theme_stylesheets array:

Array
(
    [css.php?stylesheet=18] => '<link href="http://localhost/mybb18/feature-mysql/css.php?stylesheet=18" rel="stylesheet" type="text/css">'
    [css.php?stylesheet=7] => '<link href="http://localhost/mybb18/feature-mysql/css.php?stylesheet=7" rel="stylesheet" type="text/css">'
)

Example of $style_name:
global.css

As you can see, it will never build the $stylesheets variable. This is rather urgent and apparently I missed this when merging your PR, I probably forgot to apply a change somewhere.

@euantorano
Copy link
Member

@euantorano euantorano commented Jun 26, 2014

Oh dear, that is quite a large bug. I'll fix it tonight - should be a simple fix.

On 26 Jun 2014, at 01:08, Diogo Parrinha notifications@github.com wrote:

@euantorano there is a bug here:
global.php

if(!empty($theme_stylesheets))
{
foreach($theme['disporder'] as $style_name => $order)
{
if(!empty($theme_stylesheets[$style_name]))
{
$stylesheets .= $theme_stylesheets[$style_name];
}
}
}
Example of $theme_stylesheets array:

Array
(
[css.php?stylesheet=18] => ''
[css.php?stylesheet=7] => ''
)
Example of $style_name:
global.css

As you can see, it will never build the $stylesheets variable. This is rather urgent and apparently I missed this when merging your PR, I probably forgot to apply a change somewhere.


Reply to this email directly or view it on GitHub.

@euantorano
Copy link
Member

@euantorano euantorano commented Jun 26, 2014

@PirataNervo I think the issue you're talking about is #734 which I reported here: http://community.mybb.com/thread-154565.html

@JN-Jones was going to look at this. Did you make any progress?

Either way, you made me notice I wasn't handling css.php for when it finally gets fixed, so I've now added that.

@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jun 26, 2014

@euantorano yes it might not be related to this, but I noticed it after this only :P

@euantorano
Copy link
Member

@euantorano euantorano commented Jun 26, 2014

It could well be related, but we'll see if the other patch fixes it 😉

@Eldenroot
Copy link
Contributor

@Eldenroot Eldenroot commented Jun 28, 2014

Thanks,,, keep good work!

@DiogoParrinha
Copy link
Contributor Author

@DiogoParrinha DiogoParrinha commented Jun 28, 2014

Closing this. Any bugs should be reported during Beta 2 testing period.

euantorano added a commit that referenced this issue Jun 30, 2014
Changing upload_file() to also upload to CDN if enabled as part of #776.
@Sama34 Sama34 assigned PaulBender and unassigned euantorano Jul 5, 2014
@JordanMussi JordanMussi removed the feedback label Jul 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.