Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image scaling, long word breaking and other small HTML/CSS changes #816

Closed
Destroy666x opened this issue Jun 29, 2014 · 7 comments
Closed
Assignees
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:enhancement Type: Enhancement. Contains minor improvements
Milestone

Comments

@Destroy666x
Copy link
Contributor

Adds a CSS solution for this: http://community.mybb.com/thread-154473.html
It scales big images in: announcements, PMs, posts, signatures, events, profiles, help documents, poll options, previews, new reply thread review, etc. Long word breaking was introduced as well.

It also changes some minor CSS/HTML inconsistencies (css3 in wrong stylesheet, reorder other CSS, delete selectors without attributes, add .clear , .float_left and .float_right to some templates instead of inline CSS, etc.).

I tested it twice here: http://noo.hol.es/mybb18/ and didn't find any issues so I guess it can be merged before B2 - if someone finds mistakes they can be corrected.

@JordanMussi
Copy link
Contributor

What about [code] and [php] MyCodes? Long lines of text force the container out much like an image...

@Destroy666x
Copy link
Contributor Author

^

Long word breaking was introduced as well.

I just have to fix conflicts.

@Eldenroot
Copy link
Contributor

good job! It must be tested properly

@Sama34
Copy link
Contributor

Sama34 commented Jul 17, 2014

@Destroy666x

1 similar comment
@DiogoParrinha
Copy link
Contributor

@Destroy666x

@Destroy666x
Copy link
Contributor Author

Same as the other PR done today.

@JordanMussi
Copy link
Contributor

PR was merged...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:enhancement Type: Enhancement. Contains minor improvements
Projects
None yet
Development

No branches or pull requests

5 participants