New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image scaling, long word breaking and other small HTML/CSS changes #816

Closed
Destroy666x opened this Issue Jun 29, 2014 · 7 comments

Comments

Projects
None yet
5 participants
@Destroy666x
Contributor

Destroy666x commented Jun 29, 2014

Adds a CSS solution for this: http://community.mybb.com/thread-154473.html
It scales big images in: announcements, PMs, posts, signatures, events, profiles, help documents, poll options, previews, new reply thread review, etc. Long word breaking was introduced as well.

It also changes some minor CSS/HTML inconsistencies (css3 in wrong stylesheet, reorder other CSS, delete selectors without attributes, add .clear , .float_left and .float_right to some templates instead of inline CSS, etc.).

I tested it twice here: http://noo.hol.es/mybb18/ and didn't find any issues so I guess it can be merged before B2 - if someone finds mistakes they can be corrected.

@JordanMussi

This comment has been minimized.

Show comment
Hide comment
@JordanMussi

JordanMussi Jul 4, 2014

Contributor

What about [code] and [php] MyCodes? Long lines of text force the container out much like an image...

Contributor

JordanMussi commented Jul 4, 2014

What about [code] and [php] MyCodes? Long lines of text force the container out much like an image...

@Destroy666x

This comment has been minimized.

Show comment
Hide comment
@Destroy666x

Destroy666x Jul 4, 2014

Contributor

^

Long word breaking was introduced as well.

I just have to fix conflicts.

Contributor

Destroy666x commented Jul 4, 2014

^

Long word breaking was introduced as well.

I just have to fix conflicts.

@Eldenroot

This comment has been minimized.

Show comment
Hide comment
@Eldenroot

Eldenroot Jul 7, 2014

Contributor

good job! It must be tested properly

Contributor

Eldenroot commented Jul 7, 2014

good job! It must be tested properly

@Sama34

This comment has been minimized.

Show comment
Hide comment
@Sama34
Contributor

Sama34 commented Jul 17, 2014

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo
Contributor

PirataNervo commented Jul 18, 2014

@Destroy666x Destroy666x added fixed and removed feedback labels Jul 19, 2014

Destroy666x added a commit that referenced this issue Jul 19, 2014

@Destroy666x

This comment has been minimized.

Show comment
Hide comment
@Destroy666x

Destroy666x Jul 19, 2014

Contributor

Same as the other PR done today.

Contributor

Destroy666x commented Jul 19, 2014

Same as the other PR done today.

@JordanMussi

This comment has been minimized.

Show comment
Hide comment
@JordanMussi

JordanMussi Jul 19, 2014

Contributor

PR was merged...

Contributor

JordanMussi commented Jul 19, 2014

PR was merged...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment