Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jump to Page in pagination #857

Closed
Starpaul20 opened this issue Jul 3, 2014 · 6 comments
Closed

Jump to Page in pagination #857

Starpaul20 opened this issue Jul 3, 2014 · 6 comments
Assignees
@Sama34
Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:enhancement Type: Enhancement. Contains minor improvements
Milestone
1.8 Beta 3

Comments

@Starpaul20
Copy link
Member

Add a Jump to Page in pagination
@Starpaul20 Starpaul20 added this to the 1.8 Beta 3 milestone Jul 3, 2014
@Sama34 Sama34 self-assigned this Jul 17, 2014
Sama34 pushed a commit that referenced this issue Jul 17, 2014
Implements #857 Jump to Page in pagination
779a681
@Sama34 Sama34 added feedback and removed feedback labels Jul 17, 2014
@Sama34
Copy link
Contributor

Sama34 commented Jul 17, 2014

Right, that should do it. If you wish to style it do so :P!

Thanks RateU!

Sama34 pushed a commit that referenced this issue Jul 17, 2014
Implements #857 Jump to Page in pagination
97a973b
@Sama34 Sama34 closed this as completed Jul 17, 2014
@Destroy666x
Copy link
Contributor

The template version is wrong (version="1400"). Should be 1800.

Next thing - I may be incorrect, but shouldn't the conditional be:

$pages > $mybb->settings['maxmultipagelinks']

instead of:

$pages > ($mybb->settings['maxmultipagelinks']+1)

Right now it won't show up for instance when the setting is 5 and there are 6 pages (so more than can be displayed).

Also, the new template isn't cached anywhere. Should add it to $templatelist in many places - forumdisplay, showthread, memberlist, reputation, warnings, Mod CP, managegroups, etc.

@Destroy666x Destroy666x reopened this Jul 17, 2014
@euantorano
Copy link
Member

Definitely need to add it to the template list.

@martec
Copy link
Contributor

martec commented Jul 17, 2014

why not use jquery, dropdown etc?
http://i.imgur.com/b5G9LyN.png (Phpbb 3.1)...
http://i.imgur.com/s9stq.png (I.P.B)
http://i.imgur.com/8DUPb.png (vbulletion)

@DiogoParrinha
Copy link
Contributor

@Sama34

Sama34 pushed a commit that referenced this issue Jul 19, 2014
Implements #857 Jump to Page in pagination
6b293f0
@Sama34
Copy link
Contributor

Sama34 commented Jul 19, 2014

Done.

@martec I'm not a designer nor I do know much about JavaScript. Feel free to open a PR.

This is finished. Please open a new issue for bugs, thanks!

@Sama34 Sama34 closed this as completed Jul 19, 2014
@martec martec mentioned this issue Jul 20, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sama34 Sama34

Labels
b:1.8 Branch: 1.8.x s:resolved Status: Resolved. Solution implemented or scheduled t:enhancement Type: Enhancement. Contains minor improvements
Projects
None yet
Milestone
1.8 Beta 3
Development

No branches or pull requests
6 participants
@euantorano @DiogoParrinha @Starpaul20 @Sama34 @martec @Destroy666x