New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to Page in pagination #857

Closed
PaulBender opened this Issue Jul 3, 2014 · 6 comments

Comments

Projects
None yet
6 participants
@PaulBender
Member

PaulBender commented Jul 3, 2014

Add a Jump to Page in pagination

@PaulBender PaulBender added this to the 1.8 Beta 3 milestone Jul 3, 2014

@Sama34 Sama34 self-assigned this Jul 17, 2014

Sama34 pushed a commit that referenced this issue Jul 17, 2014

@Sama34 Sama34 added feedback and removed feedback labels Jul 17, 2014

@Sama34

This comment has been minimized.

Show comment
Hide comment
@Sama34

Sama34 Jul 17, 2014

Contributor

Right, that should do it. If you wish to style it do so :P!

Thanks RateU!

Contributor

Sama34 commented Jul 17, 2014

Right, that should do it. If you wish to style it do so :P!

Thanks RateU!

Sama34 pushed a commit that referenced this issue Jul 17, 2014

@Sama34 Sama34 closed this Jul 17, 2014

@Destroy666x

This comment has been minimized.

Show comment
Hide comment
@Destroy666x

Destroy666x Jul 17, 2014

Contributor

The template version is wrong (version="1400"). Should be 1800.

Next thing - I may be incorrect, but shouldn't the conditional be:

$pages > $mybb->settings['maxmultipagelinks']

instead of:

$pages > ($mybb->settings['maxmultipagelinks']+1)

Right now it won't show up for instance when the setting is 5 and there are 6 pages (so more than can be displayed).

Also, the new template isn't cached anywhere. Should add it to $templatelist in many places - forumdisplay, showthread, memberlist, reputation, warnings, Mod CP, managegroups, etc.

Contributor

Destroy666x commented Jul 17, 2014

The template version is wrong (version="1400"). Should be 1800.

Next thing - I may be incorrect, but shouldn't the conditional be:

$pages > $mybb->settings['maxmultipagelinks']

instead of:

$pages > ($mybb->settings['maxmultipagelinks']+1)

Right now it won't show up for instance when the setting is 5 and there are 6 pages (so more than can be displayed).

Also, the new template isn't cached anywhere. Should add it to $templatelist in many places - forumdisplay, showthread, memberlist, reputation, warnings, Mod CP, managegroups, etc.

@Destroy666x Destroy666x reopened this Jul 17, 2014

@euantorano

This comment has been minimized.

Show comment
Hide comment
@euantorano

euantorano Jul 17, 2014

Member

Definitely need to add it to the template list.

Member

euantorano commented Jul 17, 2014

Definitely need to add it to the template list.

@martec

This comment has been minimized.

Show comment
Hide comment
@martec

martec Jul 17, 2014

Contributor

why not use jquery, dropdown etc?
http://i.imgur.com/b5G9LyN.png (Phpbb 3.1)...
http://i.imgur.com/s9stq.png (I.P.B)
http://i.imgur.com/8DUPb.png (vbulletion)

Contributor

martec commented Jul 17, 2014

why not use jquery, dropdown etc?
http://i.imgur.com/b5G9LyN.png (Phpbb 3.1)...
http://i.imgur.com/s9stq.png (I.P.B)
http://i.imgur.com/8DUPb.png (vbulletion)

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo
Contributor

PirataNervo commented Jul 18, 2014

Sama34 pushed a commit that referenced this issue Jul 19, 2014

@Sama34

This comment has been minimized.

Show comment
Hide comment
@Sama34

Sama34 Jul 19, 2014

Contributor

Done.

@martec I'm not a designer nor I do know much about JavaScript. Feel free to open a PR.

This is finished. Please open a new issue for bugs, thanks!

Contributor

Sama34 commented Jul 19, 2014

Done.

@martec I'm not a designer nor I do know much about JavaScript. Feel free to open a PR.

This is finished. Please open a new issue for bugs, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment