New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check new members against SFS #860

Closed
PaulBender opened this Issue Jul 3, 2014 · 12 comments

Comments

Projects
None yet
3 participants
@PaulBender
Member

PaulBender commented Jul 3, 2014

Check new members against the Stop Forum Spam database.

@PaulBender PaulBender added this to the 1.8 Beta 3 milestone Jul 3, 2014

@euantorano

This comment has been minimized.

Show comment
Hide comment
@euantorano

euantorano Jul 3, 2014

Member

This is kind of a major feature. Should really have pushed for it in beta 2.

Oh well.If nobody else takes this, I'll do it after #859. It's probably a good idea to have a few hooks in place too so other services can make use of the code (eg: spamhaus, fassim etc... similar to what my SpamTools plugin was going to do until I ran out of time to work on it).

Member

euantorano commented Jul 3, 2014

This is kind of a major feature. Should really have pushed for it in beta 2.

Oh well.If nobody else takes this, I'll do it after #859. It's probably a good idea to have a few hooks in place too so other services can make use of the code (eg: spamhaus, fassim etc... similar to what my SpamTools plugin was going to do until I ran out of time to work on it).

@euantorano euantorano self-assigned this Jul 10, 2014

@euantorano

This comment has been minimized.

Show comment
Hide comment
@euantorano

euantorano Jul 10, 2014

Member

I'll take this :) Shouldn't take too long.

Member

euantorano commented Jul 10, 2014

I'll take this :) Shouldn't take too long.

@euantorano

This comment has been minimized.

Show comment
Hide comment
@euantorano

euantorano Jul 14, 2014

Member

Started working on this in #928. It's a pretty basic implementation. Do we need to add anything else?

Member

euantorano commented Jul 14, 2014

Started working on this in #928. It's a pretty basic implementation. Do we need to add anything else?

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jul 16, 2014

Contributor

Your code seems to cover everything :P

Contributor

PirataNervo commented Jul 16, 2014

Your code seems to cover everything :P

@PirataNervo PirataNervo added the fixed label Jul 16, 2014

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jul 16, 2014

Contributor

Updated label to Fixed.

Contributor

PirataNervo commented Jul 16, 2014

Updated label to Fixed.

@euantorano

This comment has been minimized.

Show comment
Hide comment
@euantorano

euantorano Jul 16, 2014

Member

Still needs implementing in a few places such as the contact form and when posting as a guest.

On 16 Jul 2014, at 12:25, Diogo Parrinha notifications@github.com wrote:

Your code seems to cover everything :P


Reply to this email directly or view it on GitHub.

Member

euantorano commented Jul 16, 2014

Still needs implementing in a few places such as the contact form and when posting as a guest.

On 16 Jul 2014, at 12:25, Diogo Parrinha notifications@github.com wrote:

Your code seems to cover everything :P


Reply to this email directly or view it on GitHub.

@PirataNervo PirataNervo removed the fixed label Jul 16, 2014

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jul 16, 2014

Contributor

Oh you're right! Removed label.

Contributor

PirataNervo commented Jul 16, 2014

Oh you're right! Removed label.

@euantorano

This comment has been minimized.

Show comment
Hide comment
@euantorano

euantorano Jul 16, 2014

Member

😉 Should be able to apply the label tonight once it's actually finished. I need to test it with a spammy user too.

Member

euantorano commented Jul 16, 2014

😉 Should be able to apply the label tonight once it's actually finished. I need to test it with a spammy user too.

PirataNervo added a commit that referenced this issue Jul 21, 2014

Merge pull request #928 from euantorano/feature-860-check-sfs-on-regi…
…ster

Feature #860 check StopForumSpam.com on register
@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jul 21, 2014

Contributor

Merged your PR, closing this.

Contributor

PirataNervo commented Jul 21, 2014

Merged your PR, closing this.

@euantorano

This comment has been minimized.

Show comment
Hide comment
@euantorano

euantorano Jul 21, 2014

Member

Cheers. Just merged another PR cleaning up some language issues and sorting/ordering.

Member

euantorano commented Jul 21, 2014

Cheers. Just merged another PR cleaning up some language issues and sorting/ordering.

@PirataNervo

This comment has been minimized.

Show comment
Hide comment
@PirataNervo

PirataNervo Jul 21, 2014

Contributor

Now that I was doing the typecast changes....there we go fixing conflicts... :)

Contributor

PirataNervo commented Jul 21, 2014

Now that I was doing the typecast changes....there we go fixing conflicts... :)

@euantorano

This comment has been minimized.

Show comment
Hide comment
@euantorano

euantorano Jul 21, 2014

Member

😄 It's always good fun fixing conflicts.

Member

euantorano commented Jul 21, 2014

😄 It's always good fun fixing conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment