Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check new members against SFS #860

Closed
Starpaul20 opened this issue Jul 3, 2014 · 12 comments
Closed

Check new members against SFS #860

Starpaul20 opened this issue Jul 3, 2014 · 12 comments

Comments

@Starpaul20
Copy link
Member

@Starpaul20 Starpaul20 commented Jul 3, 2014

Check new members against the Stop Forum Spam database.

@Starpaul20 Starpaul20 added this to the 1.8 Beta 3 milestone Jul 3, 2014
@euantorano
Copy link
Member

@euantorano euantorano commented Jul 3, 2014

This is kind of a major feature. Should really have pushed for it in beta 2.

Oh well.If nobody else takes this, I'll do it after #859. It's probably a good idea to have a few hooks in place too so other services can make use of the code (eg: spamhaus, fassim etc... similar to what my SpamTools plugin was going to do until I ran out of time to work on it).

@euantorano euantorano self-assigned this Jul 10, 2014
@euantorano
Copy link
Member

@euantorano euantorano commented Jul 10, 2014

I'll take this :) Shouldn't take too long.

@euantorano
Copy link
Member

@euantorano euantorano commented Jul 14, 2014

Started working on this in #928. It's a pretty basic implementation. Do we need to add anything else?

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jul 16, 2014

Your code seems to cover everything :P

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jul 16, 2014

Updated label to Fixed.

@euantorano
Copy link
Member

@euantorano euantorano commented Jul 16, 2014

Still needs implementing in a few places such as the contact form and when posting as a guest.

On 16 Jul 2014, at 12:25, Diogo Parrinha notifications@github.com wrote:

Your code seems to cover everything :P


Reply to this email directly or view it on GitHub.

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jul 16, 2014

Oh you're right! Removed label.

@euantorano
Copy link
Member

@euantorano euantorano commented Jul 16, 2014

😉 Should be able to apply the label tonight once it's actually finished. I need to test it with a spammy user too.

DiogoParrinha pushed a commit that referenced this issue Jul 21, 2014
…ster

Feature #860 check StopForumSpam.com on register
@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jul 21, 2014

Merged your PR, closing this.

@euantorano
Copy link
Member

@euantorano euantorano commented Jul 21, 2014

Cheers. Just merged another PR cleaning up some language issues and sorting/ordering.

@DiogoParrinha
Copy link
Contributor

@DiogoParrinha DiogoParrinha commented Jul 21, 2014

Now that I was doing the typecast changes....there we go fixing conflicts... :)

@euantorano
Copy link
Member

@euantorano euantorano commented Jul 21, 2014

😄 It's always good fun fixing conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants