$this->options in class_parser.php

[Sama34]

Currently in class_parser.php we use the $options array instead of $this->options which is preferable.

I have tested many plug-ins in the past and I doubt any will be affected by this change. MyBB itself shouldn't be.

Reference: http://community.mybb.com/thread-57997.html

[Sama34]

    /**
     * Options for this parsed message (Private - set by parse_message argument)
     *
     * @access public
     * @var array
     */
    public $options;

Is it me being bad at English or is there a mistake?

Also, any reason for the cache_mycode(), cache_smilies(), and cache_badwords() methods to remain private?

@mybb/developers

[euantorano]

I asusme you are referencing the comment (Private - set by parse_message argument) when the parameter is actually public? If so, that's probably not a big deal - leave it public but change the comment. There may be plugins relying on it being public. I haven't seen any, but it's not a risk we can take.

[Sama34]

Yes I meant the comment, IIRC it was private and was changed at some point for that reason.

But is there any reason for the before mentioned methods to remain private? I can think of I least once where I tried to use those but couldn't.

[euantorano]

I don't see why making them public would hurt. If they could be useful outside the class, go ahead. There's no cost to doing it 😄

[Sama34]

If no one objects I will make them public and then close this then.

[JordanMussi]

@Sama34?

[Sama34]

I have been reading a little about the matter and I'm unsure whether we should make them public. That is why I'm waiting for some feedback. It is just three lines modifications so we can wait to the last day.

[DiogoParrinha]

There's nothing wrong with having public attributes, we're not following any OOP standard so we do whatever we think is best for the plugin developers :)

[Sama34]

This should be now finished.