-
-
Notifications
You must be signed in to change notification settings - Fork 419
$this->options in class_parser.php #880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
/**
* Options for this parsed message (Private - set by parse_message argument)
*
* @access public
* @var array
*/
public $options; Is it me being bad at English or is there a mistake? Also, any reason for the @mybb/developers |
I asusme you are referencing the comment ( |
Yes I meant the comment, IIRC it was private and was changed at some point for that reason. But is there any reason for the before mentioned methods to remain private? I can think of I least once where I tried to use those but couldn't. |
I don't see why making them public would hurt. If they could be useful outside the class, go ahead. There's no cost to doing it 😄 |
If no one objects I will make them public and then close this then. |
I have been reading a little about the matter and I'm unsure whether we should make them public. That is why I'm waiting for some feedback. It is just three lines modifications so we can wait to the last day. |
There's nothing wrong with having public attributes, we're not following any OOP standard so we do whatever we think is best for the plugin developers :) |
This should be now finished. |
Currently in class_parser.php we use the
$options
array instead of$this->options
which is preferable.I have tested many plug-ins in the past and I doubt any will be affected by this change. MyBB itself shouldn't be.
Reference: http://community.mybb.com/thread-57997.html
The text was updated successfully, but these errors were encountered: