Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add registration date and last active time as mass mail criteria #100

Merged
merged 4 commits into from Oct 5, 2013

Conversation

@PaulBender
Copy link
Member

@PaulBender PaulBender commented Jul 21, 2013

From my list posted here; adds registration date and the time the user was last active as mass mail criteria.

@JN-Jones
Copy link
Contributor

@JN-Jones JN-Jones commented Oct 2, 2013

This doesn't work if you set the postnum to "0" (eg. send an email to users with 0 posts).

if($conditions[$search_field] && $conditions[$direction_field])

You need to add an isset instead of simply check them (0 is assumed as false)

@JN-Jones
Copy link
Contributor

@JN-Jones JN-Jones commented Oct 5, 2013

Now we have the exactly the opposite of it: the fields are always added: string(91) "u.allownotices=1 AND u.postnum>'0' AND u.regdate<'1380971039' AND u.lastactive<'1380971039'" (haven't selected anything). It would be better to use empty. In addition it would be possible to set the time fields to "0" which isn't really necessary.

@PaulBender
Copy link
Member Author

@PaulBender PaulBender commented Oct 5, 2013

Okay, that should fix it

JN-Jones added a commit that referenced this pull request Oct 5, 2013
Add registration date and last active time as mass mail criteria
@JN-Jones JN-Jones merged commit 082c9c8 into mybb:feature Oct 5, 2013
JN-Jones added a commit that referenced this pull request Oct 5, 2013
@JN-Jones
Copy link
Contributor

@JN-Jones JN-Jones commented Oct 5, 2013

Thanks for your Pull Request.

PS: This was your first PR that was merged without conflicts :P

@PaulBender PaulBender deleted the PaulBender:feature-massmail branch Jan 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.