Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display profile fields on postbit #133

Merged
merged 2 commits into from Oct 5, 2013
Merged

Display profile fields on postbit #133

merged 2 commits into from Oct 5, 2013

Conversation

Starpaul20
Copy link
Member

From my list posted here; allows custom profile fields to be displayed on the postbit with just a simple yes/no option.

Fields are only displayed if they have been filled in by the user and are not hidden on profile.

@JN-Jones
Copy link
Contributor

JN-Jones commented Oct 2, 2013

There are 3 little issues:

  1. Textareas shouldn't be displayed:
    gh_133_1
  2. Empty Textboxes/Textareas are still diplayed (after the user has filled them first and then deleted again):
    gh_133_2
  3. The first option in multiple lists (Select and Checkboxes) isn't displayed right (see both images)

@Starpaul20
Copy link
Member Author

This commit should fix them all.

JN-Jones added a commit that referenced this pull request Oct 5, 2013
@JN-Jones
Merge pull request #133 from PaulBender/feature-postbitfields
beb977a
@JN-Jones JN-Jones merged commit 6ae81cd into mybb:feature Oct 5, 2013
@JN-Jones
Copy link
Contributor

JN-Jones commented Oct 5, 2013

Thanks for your Pull Request

@Starpaul20 Starpaul20 deleted the feature-postbitfields branch January 10, 2014 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Starpaul20 @JN-Jones