Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Hide members from the Member List #142
added a commit
this pull request
Feb 5, 2014
Shouldn't this be reversed to ...(!empty($group) && is_array($group))...? If the var is empty it won't continue with the expression whereas in its current state it would process the full expression. Also, as it seems, group's type isn't changed either from where it's defined and where the conditional appears (and doesn't seem to be used anywhere else?). If so, the check for array type is redundant and not needed either.
Yeah I noticed that when I was browsing through some files last night. I can't think of a good reason for that order. In all cases I found, albeit, probably not throughout the entire codebase, the variable in question is guaranteed to be an array (although I can see why in some cases the check is there).